Repository navigation
test: a new grant leaves existing capabilities valid (spec review r98) - #14
Merged
antoinetoussaint-byte merged 2 commits intoOct 26, 2026
Merged
antoinetoussaint-byte merged 2 commits into
antoinetoussaint-byte merged 2 commits into
Conversation
f1: the revoke case issues two capabilities, grants the holder a new role and an unrelated person a role, and requires both capabilities to still check. f2: gofmt the Go owner target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…view r108) The Viewer's author revoke ran before the viewer revoke, so the 'revoked' check passed even when the last-grant revoke invalidated nothing. Reissue the capability after the two new revokes, so the last-grant revoke must invalidate a live one. Every other revoke check already holds a capability issued just before its own revoke. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
These are the two minors from spec review r98 on the solution-principal target (#11, merged as d2e5e3e).
f1, decision (b): the model says a new grant leaves every existing capability valid, but no case proved it. The revoke case now:
author) and an unrelated person a role;An implementation that bumps a revision on every
GrantRolenow fails the target.f2:
gofmt -wonlibraries/authority-client/go/workcontext/owner_target_test.go, removing its trailing blank line.Tests
go vetis clean inlibraries/conformance/goandlibraries/authority-client/go.go test ./...passes inlibraries/authority-client/go.go test ./plugins/registry_testpasses in the local service, with the target skipped.gofmt -lis clean outside generated code.AUTHORITY_TARGET=solution-principal), and implementation (step 2) follows.🤖 Generated with Claude Code