⚡️ Speed up function _get_epsg_srs by 7%#32
Open
codeflash-ai[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
**Optimization rationale:** - Replaces `.get()`/`is None` with a direct `try/except KeyError` access pattern for `_EPSG_SRS_CACHE`, which empirical CPython benchmarks show to be faster when the hit rate is high and the value is never intended to be `None`. - `'osr.SpatialReference'` object creation and EPSG import logic are unchanged and only occur if the cache miss happens, so behavior is preserved. - No other logic or side-effects are changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 7% (0.07x) speedup for
_get_epsg_srsinopendm/tiles/gdal2tiles.py⏱️ Runtime :
298 microseconds→279 microseconds(best of181runs)📝 Explanation and details
Optimization rationale:
.get()/is Nonewith a directtry/except KeyErroraccess pattern for_EPSG_SRS_CACHE, which empirical CPython benchmarks show to be faster when the hit rate is high and the value is never intended to beNone.'osr.SpatialReference'object creation and EPSG import logic are unchanged and only occur if the cache miss happens, so behavior is preserved.✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-_get_epsg_srs-mh5rdsq0and push.