Drop items are not necessarily deep copied#294
Open
damrem wants to merge 3 commits into
Open
Conversation
Owner
|
@damrem Thanks man..! Can you add a unit test? |
Author
|
@codef0rmer Sure! I should find some time soon. |
Author
|
Hey, I've finally added tests. |
Owner
|
@damrem Thanks for adding tests. I noticed that the I do not remember If I intentionally left it to be deep copied for animation to work. Did you face any problem with that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #143 had been closed, but items still were deep copied even when settings were specifying not to do so.