Fix recorder: stop mutating shared defaultRetryOptions#5572
Merged
DavertMik merged 1 commit intoMay 18, 2026
Merged
Conversation
`Object.assign(defaultRetryOptions, retryOpts)` returned and used the
shared module-level `defaultRetryOptions` object as the merge target,
so any custom retry option (e.g. `minTimeout`, `factor`) persisted into
the defaults for every later `recorder.retry()` call.
Subsequent steps and tests then silently inherited the previous run's
overrides. A test that explicitly set `minTimeout=1000` poisoned the
defaults for the rest of the session — later steps used 1000ms even
when no `minTimeout` was passed.
Pass a fresh `{}` as the first arg to `Object.assign` so a new merged
options object is produced each call without touching the shared
defaults.
DavertMik
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
lib/recorder.js:220:Object.assign(target, source)mutatestargetand returns the same reference. By passing the module-leveldefaultRetryOptionsas the target, every custom option (minTimeout,factor,maxTimeout,retries) gets merged into the shared defaults and persists for the lifetime of the process.Subsequent
recorder.retry()calls inherit those leaked values, even when they explicitly omit them.Reproduction
Instrumentation around the
Object.assigncall:Scenario 2 fails in ~5s instead of the expected ~700ms because it inherits
minTimeout=1000from the previous scenario.Fix
Pass a fresh
{}as the first arg so a new merged object is produced each call without touching the shared defaults:Repro project
gololdf1sh/codeceptjs-retry-test.