Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/plugin/retryFailedStep.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export default function (config) {
if (step.title === ignored) return
if (ignored instanceof RegExp) {
if (step.title.match(ignored)) return
} else if (ignored.indexOf('*') && step.title.startsWith(ignored.slice(0, -1))) return
} else if (ignored.indexOf('*') !== -1 && step.title.startsWith(ignored.slice(0, -1))) return
}
enableRetry = true
})
Expand Down
30 changes: 30 additions & 0 deletions test/unit/plugin/retryFailedStep_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,36 @@ describe('retryFailedStep', () => {
// expects to retry only once
})

it('should not treat exact-name ignoredSteps entries as wildcard prefixes', async () => {
// Regression: ignored.indexOf('*') was used as truthy check.
// -1 is truthy, so entries without '*' were matched via startsWith(slice(0, -1)).
// ignoredSteps: ['see'] would silently ignore seeElement, seeInField, selectOption, etc.
retryFailedStep({ retries: 2, minTimeout: 1, ignoredSteps: ['see'] })
event.dispatcher.emit(event.test.before, createTest('test'))

let counter = 0
event.dispatcher.emit(event.step.started, { title: 'seeElement' })
try {
await recorder.add(
() => {
counter++
if (counter < 3) {
throw new Error()
}
},
undefined,
undefined,
true,
)
await recorder.promise()
} catch (e) {
await recorder.catchWithoutStop(err => err)
}

// seeElement is NOT in ignoredSteps (only 'see' is) — should be retried.
expect(counter).to.be.greaterThan(1)
})

it('should add custom regexp steps to ignore', async () => {
retryFailedStep({ retries: 2, minTimeout: 1, ignoredSteps: [/somethingNew/] })
event.dispatcher.emit(event.test.before, createTest('test'))
Expand Down
Loading