Repository navigation
fix: --ask-again closes a lost open question, and the listener reports a bad outbox file - #35
Merged
Merged
Conversation
…s a bad outbox file `pullgate status NAME --ask-again` now also removes an open question for the last tip from root's state, then asks the listener to close its message. The next run asks again with a new question ID and code. An approval for the old code finds no question and does nothing. The listener sends one notice per round when it removes an outbox file that it cannot read or parse. It names the instance and the command `pullgate status NAME --ask-again`, and shows no part of the file. When the file cannot be removed, it sends no notice. Fixes #22 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
What changes
pullgate status NAME --ask-againalso removes an open question for the last tip from root's state. After the save, it asks the listener to close the message. The next run asks again with a new question ID and a new code. An approval for the old code finds no question and does nothing, also one that was written before--ask-again(fail closed).pullgate status NAME --ask-again". It shows no part of the file. If the file cannot be removed, it sends no notice, so the chat does not get one notice per round.statushelp say what--ask-againdoes with an open question.Tests
TestAskAgainReplacesALostQuestion: open question,--ask-again, the next run asks a new question with a new ID and code; an Apply for the old code applies nothing; the new one applies.TestAskAgainDropsAnApprovalWrittenBefore: an approval for the old code that is already in the inbox applies nothing.TestAskAgainInAutoMode: the auto question is removed with no edit; the old auto approval applies nothing; the next run queues a new one.TestAskAgainKeepsAnOpenQuestionForAnotherSHA: only the question for the tip is touched.TestBadOutboxFileTellsTheOwner: an unreadable file and a broken file are removed, one notice names the instance and the command, and holds no file content.TestBadOutboxEntryThatStaysSendsNoNotice: an entry that cannot be removed gets no notice.Reviews
Security review: no critical, high or medium findings. Two low findings, both fixed: no notice when the file was not removed, and tests for auto mode and for an approval written before
--ask-again. Correctness review: no findings.🤖 Generated with Claude Code