Skip to content

feat: short SHAs in Telegram messages, the full one once per question #30

Closed

Description

@groupsky

Why

The Apply question shows full 40-character SHAs twice ("Apply this commit?" and "Since …"), and the notices do too. On a phone that is hard to read, and the owner only needs to recognize the commit: the tap is bound to the question ID, not to the SHA text.

Proposal

  • Show a short SHA (12 characters) in the text of every message, in <code>.
  • Keep the full SHA once per question, on its own line at the end ("Full: …"), so it can be copied and compared.
  • Logs, state and pullgate status keep the full SHA.

Done when

  • Questions and notices use 12-character SHAs in their text, and each question has one line with the full SHA; tests with the fake Telegram server check both.
  • A test proves that Apply installs the full SHA stored with the question, also when the message text shows only the short one.
  • README examples of messages match.

Activity

  1. groupsky commented on Nov 17, 2026

    @groupsky
    ContributorAuthor

    Done in #37 (squash commit 44afa8b).

    • 12-character SHAs in questions and notices, and one full-SHA line per question: TestShortSHAsAndOneFullSHA (message; the "Full:" line is last and stays after a cut), TestNoticesShowShortSHAs (gate), and the e2e test, through the fake Telegram server.
    • Apply installs the full SHA: TestNoticesShowShortSHAs checks that the apply command gets the full SHA and the state holds it, while the report shows only the short one.
    • README and DESIGN.md section 12 show the new message layout. THREAT-MODEL.md T3 has a note on short SHAs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestpriority: lowDo when nothing else waits

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions