You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: all text from the repo is shown only as code in messages, with link previews off #29
A commit decides its own file names and subjects, and pullgate shows them in a message from the owner's own bot, next to the Apply button. #23 is one case (a file name became a link). Fixing names one by one leaves the next field open; the rule should hold for every field by construction.
Proposal
One function builds every piece of text that comes from the repo (paths, commit subjects, author names, branch names, the summary and check output) and always puts it inside <code> or <pre>, HTML-escaped. Message code may not put repo text into a message any other way (a lint test or a type: for example a repoText type that only this function turns into a string).
All messages are sent with link previews off.
A test feeds hostile values into every field of every message kind: a URL, a domain-like name (login.example.com), README.md, HTML (<a href=…>), a Telegram entity trick (@username, #tag, /command), right-to-left marks, very long text. It checks that each value appears only inside <code>/<pre> and that the message stays under Telegram's limit.
This includes #23; close #23 with it if the same PR fixes both.
Done when
Every message kind builds repo text through the one function; a test fails if a message holds repo text outside <code>/<pre>.
The hostile-values test covers every field of every message kind.
Link previews are off for every send; a test checks the request body.
THREAT-MODEL.md: hostile text from a commit in a trusted message, and how the rule stops it.
Link previews: TestLinkPreviewsAreOff checks link_preview_options in the request body of every send and edit (question, reply, notice, expired note, edit after a tap).
THREAT-MODEL.md T3: "Hostile text shown as a link in a trusted message".
Activity
groupsky commentedon Nov 17, 2026
Fixed in #37 (squash commit 44afa8b).
message.Code() ormessage.Output(TestRepoTextIsOnlyInsideCode(every question field, with and without a cut, with a failed summary; URL, domain-like names, README.md, , @username, #tag, /command, right-to-left mark, very long text; length under the limit).TestHostileCommitTextIsOnlyCode(check-failed notice, question, failed apply) andTestHostileSymlinkRefusalIsOnlyCode(refused notice). The listener's own messages hold only instance names from its config.TestLinkPreviewsAreOffcheckslink_preview_optionsin the request body of every send and edit (question, reply, notice, expired note, edit after a tap).