Repository navigation
feat: config-diff names the store item of each secret, and marks a changed item with ⚠ - #203
Merged
Merged
Conversation
…anged item with ⚠ Each line about a new, changed or moved [secret.*], [project.*] or [logins.*] names its item, project or collection ID by its last 8 characters, such as "item …3f9a1c2e". A change of only the item is a ⚠ line. When two short forms are the same, the full IDs show. Fixes #196 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodkey broker config-diffis what the owner reads before a config change is applied. Before this change, a secret could keep a name the owner trusts and read another item, and the line did not show which item.What changes
[secret.*],[project.*]or[logins.*]names its store reference: the item ID (or project ID, collection ID) by its last 8 characters, for exampleitem …3f9a1c2e.password.⚠ secret "x": item changed from …1111aaaa to …2222bbbb.[logins.*].--shortputs them first.Tests
TestDiffNamesTheItem: new, changed and moved references for secrets (bws, 1password, infisical), projects, logins and login item rules; the same short form; the same short form in another case; two item rules with one short form.TestDiffOnlyTheItem: a change of only the item is exactly one ⚠ line.TestConfigDiffShortItem:--shortputs the item line before a narrowing line that sorts first by name.TestIDText.Reviews
A security review and a correctness review found no blocking problem. Their low findings are fixed here: the compare of short forms ignores case, two login item rules with the same short form show in full, and a change of the field, environment, path or name of a secret names the item too.
Fixes #196
🤖 Generated with Claude Code