Skip to content

feat: config-diff names the store item of each secret, and marks a changed item with ⚠ - #203

Merged
groupsky merged 1 commit into
mainfrom
feat/196-config-diff-item
Nov 17, 2026
Merged

groupsky merged 1 commit into
mainfrom
feat/196-config-diff-item

Conversation

@groupsky

Copy link
Copy Markdown
Contributor

nodkey broker config-diff is what the owner reads before a config change is applied. Before this change, a secret could keep a name the owner trusts and read another item, and the line did not show which item.

What changes

  • Each line about a new, changed or moved [secret.*], [project.*] or [logins.*] names its store reference: the item ID (or project ID, collection ID) by its last 8 characters, for example item …3f9a1c2e.
    • 1password: the field too, when it is not password.
    • Infisical: the project ID, the environment, the path and the name.
    • A move to another store names the reference too.
  • A change of only the item is one ⚠ line: ⚠ secret "x": item changed from …1111aaaa to …2222bbbb.
  • When two IDs have the same short form (also in another case), the full IDs show. The same for two item rules of one [logins.*].
  • These lines are ⚠ lines, so --short puts them first.
  • docs/setup.md "See what a config change means" shows an example line with an ID and says why. DESIGN.md and THREAT-MODEL.md say the same.

Tests

  • TestDiffNamesTheItem: new, changed and moved references for secrets (bws, 1password, infisical), projects, logins and login item rules; the same short form; the same short form in another case; two item rules with one short form.
  • TestDiffOnlyTheItem: a change of only the item is exactly one ⚠ line.
  • TestConfigDiffShortItem: --short puts the item line before a narrowing line that sorts first by name.
  • TestIDText.

Reviews

A security review and a correctness review found no blocking problem. Their low findings are fixed here: the compare of short forms ignores case, two login item rules with the same short form show in full, and a change of the field, environment, path or name of a secret names the item too.

Fixes #196

🤖 Generated with Claude Code

…anged item with ⚠

Each line about a new, changed or moved [secret.*], [project.*] or
[logins.*] names its item, project or collection ID by its last 8
characters, such as "item …3f9a1c2e". A change of only the item is a ⚠
line. When two short forms are the same, the full IDs show.

Fixes #196

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@groupsky
groupsky merged commit c1204ca into main Nov 17, 2026
7 checks passed
@groupsky
groupsky deleted the feat/196-config-diff-item branch November 17, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: config-diff names the store item of each secret, and flags a changed item as ⚠

1 participant