Repository navigation
Conversation
5 tasks
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…prefix (#125) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e phone (#125) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…irmed, conflict, bad token (#125) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….md and the manual test (#125) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Harden the process before the token is read; the guard test covers the Telegram parts of the trial; Format with value receivers; T38 says that either poller may stop on a conflict. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main added checks 16 and 17 (1Password, Infisical). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- check that no trial runs before the pairing polls the bot - a signal during the setup ends with exit code 0; the end of the input says what to do - every new error says how to fix it; the usage error names --telegram - Options.Prefix is at most 32 characters, and every message keeps room for it - the token is trimmed as bytes - THREAT-MODEL T38: what a pasted broker token gives the agent, and the removed buttons Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…telegram (#125) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
groupsky
force-pushed
the
feat/125-try-telegram
branch
from
November 18, 2026 05:44
998e99a to
0b97ca2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #125
Stage 2:
nodkey try --telegram, approval on a phone with a new bot. Stage 1 (approval in the terminal) was #143.Behavior for callers
Changes behavior for existing callers: no
nodkey try --telegramis new.nodkey trywithout the flag,nodkey runandnodkey brokerkeep their behavior. The only change outside the trial: the body of a Telegram message is cut 32 characters earlier, to keep room forOptions.Prefix.Progress
internal/telegram:NewWithToken(token only in memory),Options.Prefix(TRY MODE before every message and edit, at most 32 characters),NewPairing/Wait(getMe, the link, the user ID only from/start CODEin a private chat). Tests:TestPairing*,TestPrefix,TestPrefixRoom,TestNewWithToken.nodkey try --telegram(cmd/nodkey/trytelegram.go): hidden token input (echo off), the/startlink with a random code, confirm the name withyes, the Telegram approver with TRY MODE, a clear text on a conflictcmd/nodkey:TestTryTelegram,TestTryTelegramNotConfirmed,TestTryTelegramConflict,TestTryTelegramBadToken,TestTryTelegramInputEnds,TestTryTelegramSignalInSetup,TestTryTelegramWhileATrialRunsFixed after the rebase (review findings)
nodkey try --telegramchecks that no trial runs before it polls the bot, so it cannot stop a running trial with a conflict.--telegram. The conflict text no longer shows two exit codes.Options.Prefixis at most 32 characters, and every message, also a notice, keeps room for it.Not fixed on purpose (low)
checkNoTrialtakes no lock, so a trial that starts while another waits for its token can still meet it on one bot. Both then deny and stop; nothing is left behind.Choices
telegram.Pairing(getMe, then/start CODEin a private chat with its sender). feat: guided broker setup (nodkey setup broker) #98 step 5 can reuse it.telegram.Options.Prefix, added in the client to the text of everysendMessageandeditMessageText.isTerminalalready does: no new dependency.Next
Geno runs check 18 of
docs/manual-telegram-test.mdand posts the rows on #125. Then a later session adds the results to the docs, marks this ready, merges it and closes #125.🤖 Generated with Claude Code