You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: TestLoginRememberedTimer is flaky in CI with Go stable #205
TestLoginRememberedTimer/the_broker's_timer (internal/broker/remembered_test.go:614) fails often in the test (stable) CI job, with Go 1.27.4:
remembered_test.go:614: value 2 that the store gave out is not cleared
remembered_test.go:614: value 3 that the store gave out is not cleared
Seen on 2026-11-16 and 2026-11-17, on the release pull request branch and on #204, which do not touch internal/broker. On #204 it failed three runs in a row and passed on the fourth. It passes locally, also in the full go test -race ./.... TestFloodOfBadAnswers (internal/ntfy/approver_test.go:249, "the approver keeps 1 values, want 0") failed once in the same runs.
The test likely checks the cleared values before the code that clears them has run (a race in the test, not in the broker), but this is not checked yet.
Done when
The cause is found and written in the pull request.
TestLoginRememberedTimer and TestFloodOfBadAnswers pass 20 runs in a row with go test -race -count=20 -run '...' on a CI runner.
If the cause is in the broker, not the test, a test covers the deny path.
Activity