Repository navigation
[pull] main from ueberdosis:main - #212
Merged
Merged
Conversation
…ting a list item at its start `Transform.split(pos, depth, typesAfter)` only applies `typesAfter` to the node created after the split, so `splitListItem` always handed the reset attributes to the trailing item. When the cursor is at the start of the item, the empty new item is the leading one, so the reset landed on the wrong half: pressing Enter before the text of a checked task item left the empty item checked and unchecked the item that kept the text. Detect that case and swap the roles: the trailing item keeps the attributes of the item being split, and the reset is applied to the leading item with setNodeMarkup after the split. This is generic to any `keepOnSplit: false` list attribute. Fixes #6289
…input rule The rule's `find` was a regex literal containing `(?<!...)`. WebKit older than Safari 16.4 rejects lookbehind while parsing the literal, so the failure takes down the whole chunk the extension is bundled into rather than only this rule. Rewriting the pattern is not an option: #6731 replaced the lookbehind with a consuming `(^|[^$])` group, which makes the preceding character part of the match, and since the input rule range is derived from the match length that character was replaced along with the math. #7481 reverted it by restoring the lookbehind. Use a function finder instead. `InputRuleFinder` accepts `(text) => InputRuleMatch | null`, so the preceding character can be inspected without consuming it, and the returned `text` stays exactly the `$$latex$$` sequence the range is computed from. The latex moves from `match[2]` to `match.data`, since a function finder builds the match array from its returned `text` alone. A rejected match is retried from the character after its start rather than from its end, because a valid match can begin inside a rejected one at its trailing `$$`.
…erms State the crash in older WebKit instead of the regex that caused it.
…editor fix(core): skip cross-editor drop cleanup for a destroyed source editor
fix(extension-mathematics): drop the lookbehind from the inline math input rule
…-on-content-half fix(core): keep keepOnSplit attributes on the content half when splitting a list item at its start
…sing-tag fix(static-renderer): close audio and video tags instead of self-closing them
docs: update onClick handler to include position parameter
fix(static-renderer): join nested child specs without commas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )