Repository navigation
[pull] main from ueberdosis:main - #211
Merged
Merged
Conversation
…views NodeView.ignoreMutation returned true for every mutation when the node view has no contentDOM, selection mutations included. When the browser places the caret inside such a node view, for example after ArrowUp in Firefox or a click on the node's text, ProseMirror never re-read the selection, the caret stayed inside the non-editable DOM and typed text was lost. Return false for selection mutations in that case, matching ProseMirror's own default for leaf nodes and the existing behaviour for node views with a contentDOM. Fixes: #8369 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-fable-5.1
fix(core): let ProseMirror handle selection changes inside leaf node views
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )