Repository navigation
[pull] main from ueberdosis:main - #209
Merged
Merged
Conversation
splitBlock checked canSplit on the document as it was before deleteSelection ran, then executed the split on the document after the deletion. When deleting the selection restructures the document (for example a selection from the start of one block into another block, or across an isolating node), the validated position no longer exists and tr.split throws an uncaught TransformError: Inserted content deeper than insertion position. The split is now validated against the document as it will look after the deletion, by simulating deleteSelection on a scratch transaction. The shared transaction stays untouched until the split is known to be possible, because it is dispatched (and shared with chained commands) even when a command returns false. This restores the ordering used by prosemirror-commands splitBlockAs, where deleteSelection runs before canSplit. Fixes #7734
fix(core): validate splitBlock against the post-deleteSelection document
fix: pin optional bubble/floating-menu deps with workspace:*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )