[pull] dev from mrdoob:dev

examples/jsm/lighting/vxgi/VXGINode.js

@@ -633,6 +633,8 @@ class VXGINode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._renderTarget.dispose();
 		this._material.dispose();
 		this.volume.dispose();

examples/jsm/tsl/display/AfterImageNode.js

@@ -231,6 +231,8 @@ class AfterImageNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._compRT.dispose();
 		this._oldRT.dispose();
 

examples/jsm/tsl/display/BilateralBlurNode.js

@@ -324,6 +324,8 @@ class BilateralBlurNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._horizontalRT.dispose();
 		this._verticalRT.dispose();
 

examples/jsm/tsl/display/BloomNode.js

@@ -467,6 +467,8 @@ class BloomNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		for ( let i = 0; i < this._renderTargetsHorizontal.length; i ++ ) {
 
 			this._renderTargetsHorizontal[ i ].dispose();

examples/jsm/tsl/display/DenoiseNode.js

@@ -266,10 +266,10 @@ class DenoiseNode extends TempNode {
 	 */
 	dispose() {
 
-		this._noiseTexture.dispose();
-
 		super.dispose();
 
+		this._noiseTexture.dispose();
+
 	}
 
 }

examples/jsm/tsl/display/DepthOfFieldNode.js

@@ -534,6 +534,8 @@ class DepthOfFieldNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._CoCRT.dispose();
 		this._CoCBlurredRT.dispose();
 		this._blur64RT.dispose();

examples/jsm/tsl/display/FSR1Node.js

@@ -454,6 +454,8 @@ class FSR1Node extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._easuRT.dispose();
 		this._rcasRT.dispose();
 

examples/jsm/tsl/display/GTAONode.js

@@ -596,6 +596,8 @@ class GTAONode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._aoRenderTarget.dispose();
 
 		this._noiseTexture.dispose();

examples/jsm/tsl/display/GodraysNode.js

@@ -593,6 +593,8 @@ class GodraysNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._godraysRenderTarget.dispose();
 
 		this._material.dispose();

examples/jsm/tsl/display/LensflareNode.js

@@ -253,6 +253,8 @@ class LensflareNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._renderTarget.dispose();
 		this._material.dispose();
 

examples/jsm/tsl/display/OutlineNode.js

@@ -748,6 +748,8 @@ class OutlineNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this.selectedObjects.length = 0;
 
 		this._renderTargetDepthBuffer.dispose();

examples/jsm/tsl/display/RecurrentDenoiseNode.js

@@ -890,6 +890,8 @@ class RecurrentDenoiseNode extends TempNode {
 
 	dispose() {
 
+		super.dispose();
+
 		this._renderTarget.dispose();
 		this._material.dispose();
 

examples/jsm/tsl/display/SMAANode.js

@@ -675,6 +675,8 @@ class SMAANode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._renderTargetEdges.dispose();
 		this._renderTargetWeights.dispose();
 		this._renderTargetBlend.dispose();

examples/jsm/tsl/display/SSAONode.js

@@ -409,6 +409,8 @@ class SSAONode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._aoRenderTarget.dispose();
 		this._blurRenderTarget.dispose();
 

examples/jsm/tsl/display/SSGINode.js

@@ -665,6 +665,8 @@ class SSGINode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._ssgiRenderTarget.dispose();
 
 		this._material.dispose();

examples/jsm/tsl/display/SSRNode.js

@@ -1317,6 +1317,8 @@ class SSRNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._ssrRenderTarget.dispose();
 		this._blurRenderTarget.dispose();
 

examples/jsm/tsl/display/SSSNode.js

@@ -468,6 +468,8 @@ class SSSNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._sssRenderTarget.dispose();
 
 		this._material.dispose();

examples/jsm/tsl/display/SharpenNode.js

@@ -259,6 +259,8 @@ class SharpenNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._renderTarget.dispose();
 
 		if ( this._material !== null ) this._material.dispose();

examples/jsm/tsl/display/TAAUNode.js

@@ -791,6 +791,8 @@ class TAAUNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._historyRenderTarget.dispose();
 		this._resolveRenderTarget.dispose();
 		this._previousDepthRenderTarget.dispose();

examples/jsm/tsl/display/TRAANode.js

@@ -722,6 +722,8 @@ class TRAANode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this._historyRenderTarget.dispose();
 		this._resolveRenderTarget.dispose();
 

examples/jsm/tsl/display/TemporalReprojectNode.js

@@ -983,6 +983,8 @@ class TemporalReprojectNode extends TempNode {
 
 	dispose() {
 
+		super.dispose();
+
 		this._previousNormalTexture.dispose();
 
 		if ( this._previousDepthNode.value !== this._historyRenderTarget.depthTexture ) {

src/nodes/accessors/StorageTextureNode.js

@@ -260,7 +260,8 @@ class StorageTextureNode extends TextureNode {
 
 		const textureProperty = super.generate( builder, 'property' );
 		const uvSnippet = uvNode.build( builder, this.value.is3DTexture === true ? 'uvec3' : 'uvec2' );
-		const storeSnippet = storeNode.build( builder, 'vec4' );
+		const storeType = builder.getTypeFromLength( 4, builder.getComponentTypeFromTexture( this.value ) );
+		const storeSnippet = storeNode.build( builder, storeType );
 		const depthSnippet = depthNode ? depthNode.build( builder, 'int' ) : null;
 
 		const snippet = builder.generateTextureStore( this.value, textureProperty, uvSnippet, depthSnippet, storeSnippet );

src/nodes/display/PassNode.js

@@ -1039,6 +1039,8 @@ class PassNode extends TempNode {
 	 */
 	dispose() {
 
+		super.dispose();
+
 		this.renderTarget.dispose();
 
 	}

src/nodes/gpgpu/ComputeNode.js

@@ -110,15 +110,6 @@ class ComputeNode extends Node {
 
 	}
 
-	/**
-	 * Executes the `dispose` event for this node.
-	 */
-	dispose() {
-
-		this.dispatchEvent( { type: 'dispose' } );
-
-	}
-
 	/**
 	 * Sets the {@link ComputeNode#name} property.
 	 *

src/renderers/webgl-fallback/WebGLBackend.js

@@ -1266,7 +1266,7 @@ class WebGLBackend extends Backend {
 
 			const renderTarget = this._currentContext.renderTarget;
 
-			const pixelRatio = renderTarget !== null ? 1 : this.renderer.getPixelRatio();
+			const pixelRatio = ( renderTarget === null || renderTarget.isPostProcessingRenderTarget === true ) ? this.renderer.getPixelRatio() : 1;
 			const isRenderCameraDepthArray = this._isRenderCameraDepthArray( this._currentContext );
 			const prevActiveCubeFace = this._currentContext.activeCubeFace;
 

src/renderers/webgl-fallback/nodes/GLSLNodeBuilder.js

@@ -11,7 +11,7 @@ import { error } from '../../../utils.js';
 
 const glslPolyfills = {
 	bitcast_int_uint: new CodeNode( /* glsl */'uint tsl_bitcast_int_to_uint ( int x ) { return floatBitsToUint( intBitsToFloat ( x ) ); }' ),
-	bitcast_uint_int: new CodeNode( /* glsl */'uint tsl_bitcast_uint_to_int ( uint x ) { return floatBitsToInt( uintBitsToFloat ( x ) ); }' ),
+	bitcast_uint_int: new CodeNode( /* glsl */'int tsl_bitcast_uint_to_int ( uint x ) { return floatBitsToInt( uintBitsToFloat ( x ) ); }' ),
 	textureGather: new CodeNode( /* glsl */`
 vec4 tsl_textureGather( const int comp, sampler2D map, vec2 coord, ivec2 offset, bool flipY ) {
 	if ( flipY ) offset.y = - offset.y;
@@ -873,21 +873,8 @@ ${ flowData.code }
 				const textureNode = uniform.node;
 				const texture = textureNode.value;
 
-				let typePrefix = '';
-
-				if ( texture.isDataTexture === true || texture.isData3DTexture === true ) {
-
-					if ( texture.type === UnsignedIntType ) {
-
-						typePrefix = 'u';
-
-					} else if ( texture.type === IntType ) {
-
-						typePrefix = 'i';
-
-					}
-
-				}
+				const componentType = this.getComponentTypeFromTexture( texture );
+				const typePrefix = componentType === 'float' ? '' : componentType.charAt( 0 );
 
 				if ( uniform.type === 'texture3D' && texture.isArrayTexture === false ) {
 

src/renderers/webgpu/WebGPUBackend.js

@@ -2257,7 +2257,8 @@ class WebGPUBackend extends Backend {
 
 			}
 
-			const pixelRatio = context.renderTarget !== null ? 1 : this.renderer.getPixelRatio();
+			const renderTarget = context.renderTarget;
+			const pixelRatio = ( renderTarget === null || renderTarget.isPostProcessingRenderTarget === true ) ? this.renderer.getPixelRatio() : 1;
 			const indexPos = cameraIndex ? bindings.indexOf( cameraIndex ) : - 1;
 
 			for ( let i = 0, len = cameras.length; i < len; i ++ ) {

src/renderers/webgpu/nodes/WGSLNodeBuilder.js

@@ -2202,11 +2202,13 @@ ${ flowData.code }
 
 				} else if ( texture.isArrayTexture === true || texture.isDataArrayTexture === true || texture.isCompressedArrayTexture === true ) {
 
-					textureType = 'texture_2d_array<f32>';
+					const componentPrefix = this.getComponentTypeFromTexture( texture ).charAt( 0 );
+					textureType = `texture_2d_array<${ componentPrefix }32>`;
 
 				} else if ( texture.is3DTexture === true || texture.isData3DTexture === true ) {
 
-					textureType = 'texture_3d<f32>';
+					const componentPrefix = this.getComponentTypeFromTexture( texture ).charAt( 0 );
+					textureType = `texture_3d<${ componentPrefix }32>`;
 
 				} else {
 

test/unit/addons/tsl/TSLBitOps.tests.js

@@ -24,6 +24,19 @@ export default QUnit.module( 'TSL', () => {
 
 		} );
 
+		gpuTest( 'bitcast() reinterprets bits between int and uint', ( { assert } ) => {
+
+			// -1's two's-complement bit pattern (0xFFFFFFFF) read as unsigned
+			// is the largest uint32 value.
+			assert.eq( bitcast( int( - 1 ), 'uint' ), uint( 4294967295 ), 'bitcast(-1, "uint") == 0xFFFFFFFF' );
+			assert.eq( bitcast( uint( 4294967295 ), 'int' ), int( - 1 ), 'bitcast(0xFFFFFFFF, "int") == -1' );
+
+			// Round trip: bitcast is lossless reinterpretation, so converting
+			// out and back must recover the exact original value.
+			assert.eq( bitcast( bitcast( int( - 42 ), 'uint' ), 'int' ), int( - 42 ), 'bitcast round trip recovers the exact int' );
+
+		} );
+
 	} );
 
 	QUnit.module( 'bit counting', () => {