Skip to content

[pull] dev from mrdoob:dev #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Aug 11, 2026
Merged

[pull] dev from mrdoob:dev #1559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified examples/screenshots/webgpu_mesh_batch.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified examples/screenshots/webgpu_shadowmap_array.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/objects/BatchedMesh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ class BatchedMesh extends Mesh {
this._multiDrawCounts = new Int32Array( maxInstanceCount );
this._multiDrawStarts = new Int32Array( maxInstanceCount );
this._multiDrawCount = 0;
this._multiDrawBytesPerElement = 1;

// Local matrix per geometry by using data texture
this._matricesTexture = null;
Expand Down Expand Up @@ -1474,6 +1475,7 @@ class BatchedMesh extends Mesh {
this._geometryInitialized = source._geometryInitialized;
this._multiDrawCounts = source._multiDrawCounts.slice();
this._multiDrawStarts = source._multiDrawStarts.slice();
this._multiDrawBytesPerElement = source._multiDrawBytesPerElement;

this._indirectTexture = source._indirectTexture.clone();
this._indirectTexture.image.data = this._indirectTexture.image.data.slice();
Expand Down Expand Up @@ -1678,6 +1680,7 @@ class BatchedMesh extends Mesh {

indirectTexture.needsUpdate = true;
this._multiDrawCount = multiDrawCount;
this._multiDrawBytesPerElement = bytesPerElement;
this._visibilityChanged = false;

}
Expand Down
9 changes: 1 addition & 8 deletions src/renderers/webgpu/WebGPUBackend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2114,14 +2114,7 @@ class WebGPUBackend extends Backend {
const starts = object._multiDrawStarts;
const counts = object._multiDrawCounts;
const drawCount = object._multiDrawCount;

let bytesPerElement = ( hasIndex === true ) ? index.array.BYTES_PER_ELEMENT : 1;

if ( material.wireframe ) {

bytesPerElement = object.geometry.attributes.position.count > 65535 ? 4 : 2;

}
const bytesPerElement = object._multiDrawBytesPerElement;

for ( let i = 0; i < drawCount; i ++ ) {

Expand Down