Skip to content

[pull] dev from mrdoob:dev #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Jul 30, 2026
Merged

[pull] dev from mrdoob:dev #1538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de6b824
WebGLBackend: Fix usage of `storeMultisampledDepthBuffer`. (#34142)
Mugen87 Jul 30, 2026
eba30de
Update Renderer.js
Mugen87 Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/renderers/common/Renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,7 +1511,9 @@ class Renderer {

_renderOutputLayers( quad, renderTarget ) {

if ( renderTarget.texture.isArrayTexture !== true || renderTarget.texture.image.depth <= 1 ) {
const useMultiview = this.backend.isWebGLBackend === true && renderTarget.multiview === true;

if ( useMultiview || renderTarget.texture.isArrayTexture !== true || renderTarget.texture.image.depth <= 1 ) {

this._renderScene( quad, quad.camera, false );
return;
Expand Down
4 changes: 0 additions & 4 deletions src/renderers/common/XRManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,8 +958,6 @@ class XRManager extends EventDispatcher {
storeMultisampledStencilBuffer: false
} );

renderTarget._autoAllocateDepthBuffer = true;

const material = new MeshBasicMaterial( { color: 0xffffff, side: FrontSide } );
material.map = renderTarget.texture;
material.map.offset.y = 1;
Expand Down Expand Up @@ -1051,8 +1049,6 @@ class XRManager extends EventDispatcher {
storeMultisampledStencilBuffer: false
} );

renderTarget._autoAllocateDepthBuffer = true;

const material = new MeshBasicMaterial( { color: 0xffffff, side: BackSide } );
material.map = renderTarget.texture;
material.map.offset.y = 1;
Expand Down
3 changes: 2 additions & 1 deletion src/renderers/webgl-fallback/WebGLBackend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2886,7 +2886,8 @@ class WebGLBackend extends Backend {

}

} else if ( renderTarget.storeMultisampledDepthBuffer === false && renderTargetContextData.framebuffers ) {
} else if ( this._supportsInvalidateFramebuffer === true && renderTargetContextData.framebuffers &&
( renderTarget._autoAllocateDepthBuffer === true || ( renderTarget.samples > 0 && renderTarget.storeMultisampledDepthBuffer === false ) ) ) {

const fb = renderTargetContextData.framebuffers[ renderContext.getCacheKey() ];
state.bindFramebuffer( gl.DRAW_FRAMEBUFFER, fb );
Expand Down