Skip to content

[pull] dev from mrdoob:dev #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Jun 27, 2026
Merged

[pull] dev from mrdoob:dev #1458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5345d21
WebGPURenderer: Fix background rotation with nodes. (#33892)
Mugen87 Jun 27, 2026
94f64a9
TSL: Fix crash in `MRT` when output is not bound by RenderTarget (#33…
sunag Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/nodes/accessors/SceneProperties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const backgroundRotation = /*@__PURE__*/ uniform( new Matrix4() ).setGrou

const background = scene.background;

if ( background !== null && background.isTexture && background.mapping !== UVMapping ) {
if ( ( background !== null && background.isTexture && background.mapping !== UVMapping ) || ( scene.backgroundNode && scene.backgroundNode.isNode ) ) {

// note: since the matrix is orthonormal, we can use the more-efficient transpose() in lieu of invert()
_m1.makeRotationFromEuler( scene.backgroundRotation ).transpose();
Expand Down
4 changes: 4 additions & 0 deletions src/nodes/core/MRTNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,10 @@ class MRTNode extends OutputStructNode {
for ( const name in outputNodes ) {

const index = getTextureIndex( textures, name );

// Ignore if the output exists in the MRT but has never been used.
if ( index === - 1 ) continue;

const type = builder.getOutputType( index );

members[ index ] = outputNodes[ name ].convert( type );
Expand Down
Loading