Skip to content

[pull] dev from mrdoob:dev #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Jun 23, 2026
+10 −9
Merged

[pull] dev from mrdoob:dev #1449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/nodes/core/NodeBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2268,28 +2268,29 @@ class NodeBuilder {
const shaderStage = this.shaderStage;
const declarations = this.declarations[ shaderStage ] || ( this.declarations[ shaderStage ] = {} );

const property = this.getPropertyName( node );
const baseName = node.name;

let name = baseName;
let property = this.getPropertyName( node );
let index = 1;
let name = property;

// Automatically renames the property if the name is already in use.

while ( declarations[ name ] !== undefined ) {
while ( declarations[ property ] !== undefined ) {

name = property + '_' + index ++;
name = baseName + '_' + index ++;
node.name = name;
property = this.getPropertyName( node );

}

if ( index > 1 ) {

node.name = name;
if ( name !== baseName ) {

warn( `TSL: Declaration name '${ property }' of '${ node.type }' already in use. Renamed to '${ name }'.` );
warn( `TSL: Declaration name '${ baseName }' of '${ node.type }' already in use. Renamed to '${ name }'.` );

}

declarations[ name ] = node;
declarations[ property ] = node;

}

Expand Down
Loading