Conversation
…uires (#49615) # Why `ncc` in `install-expo-modules` was failing sporadically, but this was due to an underlying issue: - `package.json` with a relative require was unreliable and causing the entire package to re-include itself - if `build` then contained package outputs, this would recursively retrigger the above issue Some dependencies were also missing dependencies on `@vercel/ncc`, which is an unrelated issue. # How - Update all patterns of `require('../package.json')` to name the module as a self-require - ... and add `exports['./package.json']` entries to `package.json` corresponding to this - Add `pre*` scripts for `build` scripts that run `expo-module clean` to delete the `build` folder before bundling with ncc - Where needed, update all related `package.json` require patterns - Where needed, add missing `@vercel/ncc` dev deps # Test Plan - Build should pass on CI # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why iOS `.strings` entries generated from `locales` were not safely quoted, so human-readable keys such as widget names could produce invalid files. This is the config-plugin prerequisite for #49606. # How Quote every key and value and escape backslashes, quotes, and newlines. # Test Plan Tests should pass. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why Fixes #48687. Widget gallery names and descriptions cannot resolve app-config translations because `Localizable.strings` is only included in the main app target. # How Add the app's existing `Localizable.strings` file references to the widget extension's Resources phase. This reuses the same source files without generating widget-specific copies. This PR is stacked on #49605 for valid human-readable string keys. # Test Plan Tests should pass. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )