Conversation
# Why Min iOS version is `16.4` anyway. # How Removed `available(iOS 16, *)` checks. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
# Why This tests started to fail when I introduced navigation queue using context. Codex claims, the failures were due to old loader data still being shown on the screen. https://github.com/expo/expo/actions/runs/32878613868/job/97902823552 # How 1. Assert not only loader-data presence, but also its content # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why https://github.com/expo/expo/actions/runs/32961267901/job/98153986352#step:11:196 Based on this error and further debugging codex came to the conclusion that the hidden `#520` error is `Update hook called on initial render` and proposed this fix. # How <!-- How did you build this feature or fix this bug and why? --> # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why In order to support react-transitions, we need to move the routing queue to react tree. This PR adds routing queue context which is used to process all navigation events executed using non-global API - `useRouter` # How 1. Add two contexts - One for `enqueue`/`dequeue` which is stable - it only adds and removes from the state. Another one for `intents` - the state which changes. The second context is only used to dispatch the state updates 2. Modify all navigation approaches - `useRouter`, `Link`, `useDomComponentNavigation`, `useNavigationHelpers` to use the context queue 3. Add a bridge which passes the context queue to the non-react queue during first render 4. Fix loader tests, by awaiting their data rather then only the locator # Test Plan 1. CI 2. Router e2e # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
…ke findings comments)
…istent `initial` prop (#49411) Co-authored-by: Aman Mittal <amandeepmittal@live.com>
… are omitted, not placeholders
# Why While backporting `@expo/env` to SDK 57, I realized that a dotenv file can add `__EXPO_CONFIG_MODE` back through `EXPO_UNSAFE_DOTENV_KEYS` after Expo removes the internal handoff. # How Now we check for `__EXPO_CONFIG_MODE` and throw if a dotenv file tries to add it back. # Test Plan All tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )