[pull] master from apify:master - #276
Merged
Merged
Conversation
) Restores the #3923 fix that the v4 rebase silently reverted. The enqueueLinks split (#4010) predates #3923 and its diff carried a pre-fix copy of `resolveBaseUrlForEnqueueLinksFiltering`; when the rebase replayed it over the fixed base, the rerere cache (seeded from the old merge branch, which had resolved this exact conflict toward v4) applied that resolution again, so the fix disappeared without ever showing a conflict. The result: with `strategy: 'same-domain'` and a cross-domain redirect, the `undefined` baseUrl built no strategy patterns and every link on the redirected page got enqueued. The regression test runs the real CheerioCrawler path with an http client that reports an off-domain load. An audit of all v3 fixes since 3.14 against master found no other fix dropped by the rebase. Closes #4070
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )