[pull] master from apify:master - #274
Merged
Merged
Conversation
## Summary `Build & Test` has no `timeout-minutes`, so it inherits GitHub's 6h default. A green run takes about 5 to 10 minutes, but a flaky test that leaks a handle (an orphan node process that never exits) hangs the whole job until the 6h kill. That burns a runner and leaves the PR red for hours. This just happened on #4052: node 22 and 26 hung to the 6h limit while node 24 passed in about 10 minutes, and a plain rerun then passed all three in about 5 minutes. Same code, same PR, so it was a flaky hang rather than a real failure. Capping the job at 30 minutes keeps a wide margin over a normal run while failing fast on these hangs. `test-e2e.yml` already sets a step-level timeout, so this follows existing practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )