[pull] master from apify:master - #270
Merged
Merged
Conversation
This pins every third-party action in our workflows to a full commit SHA, keeping the resolved version tag as a trailing comment. Renovate understands that convention and updates the SHA and comment together. The trigger: yesterday the `v11` tag of `EndBug/add-and-commit` moved to the broken v11.1.0 release, whose `action.yml` fails to load (`Unrecognized named-value: 'github'`), which killed our publish workflow ([failed run](https://github.com/apify/crawlee/actions/runs/32255557318)). With SHA pins, a tag moving under us, by accident or by compromise, can't break or hijack CI anymore. `EndBug/add-and-commit` is pinned to v11.0.0, the last working release; the upstream fix is pending in EndBug/add-and-commit#783. Own-org references (`apify/workflows`, `apify/actions`, `apify/setup-apify-cli-action`) stay on floating refs on purpose, since we control those repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )