[pull] main from SigNoz:main - #952
Merged
Merged
Conversation
…12707) #### Description Post Dashboard v1 cleanup, codeowners update #### Additional Information Closes SigNoz/pulse-pod#325
The V1 variable engine had no writers left: nothing wrote selectedValue, so getDashboardVariables produced undefined values, variableFetchStore was never updated, and the dependency graph and derived store fields only fed that store. The shared store's one remaining job is publishing the open dashboard's dynamic variables for query-builder autocomplete, which needs a name and an attribute. Replace it with a suggestion feed and delete the rest, including the panel variables prop that no GridCard caller passed and useResolveQuery's dashboardData option that no caller supplied. useGetResolvedText loses its only variable source and becomes the title truncation its callers already used it for. <!--A few plain bullets saying what changed and why, for a reviewer skimming it - not a wall of text, not a restatement of the diff, not generated boilerplate.--> #### Description <!--Reference issues using `Closes #issue-number` to enable automatic closure on merge. --> #### Issues closed by this PR Closes SigNoz/pulse-pod#326 <!--If applicable, include screenshots or screen recordings that clearly show the behavior before the change and the result after the change. --> #### Screenshots / Screen Recordings <!--Anything reviewers should keep in mind while reviewing --> #### Additional Information <!--Please delete paragraphs that you did not use before submitting.-->
…of inferring them from panel types (#12559) #### Description V2 panels answered "how does this panel's query behave?" by comparing against the legacy `PANEL_TYPES` enum. Each kind now declares it, so adding a kind means stating its behaviour once instead of finding every switch that should have mentioned it. - **Kinds declare their query behaviour** — request type, table formatting, step-interval and order treatment, paging, list-view authoring, trace operator. `buildQueryRangeRequest` takes that block, so the `PANEL_TYPES.BAR` / `.LIST` / `.TABLE` branches are gone. An exhaustive `Record<PanelKind, …>` test means a new kind can't ship without declaring its request shape. - **The capabilities are passed in, not looked up.** The panel registry carries every renderer with it, so importing it into the data path drags the app's API client into anything that touches the request builder. The call sites already resolve the definition. - **The chart layer no longer infers a time axis from a panel type.** `UPlotAxisBuilder` decided X-axis date formatting from a hardcoded `[TIME_SERIES, BAR]` list, so a chart that plots time but isn't one of those two silently lost its formatted ticks — no type error, no failing test. Callers now declare `isTimeAxis`. - **`getPanelDefinition` always resolves.** It was typed to return a definition for any `PanelKind`, but the registry only holds registered kinds, and a spec from a newer SigNoz names one this build has never heard of. Callers coped by truthiness-checking a value the type said couldn't be falsy — a lint autofix had already deleted one such guard in `PublicPanel`. Unknown kinds now resolve to `UNSUPPORTED_PANEL`, which declares nothing and renders as unsupported; `isPanelKindSupported` is the separate question the lazy fetch and editor session actually needed. - **Analytics gained `panelKind`** on all seven panel events, alongside the existing `panelType` so current reports keep resolving. `panelType` can't distinguish two kinds that map onto it. - **Removed `ViewPanelQueryBuilder`** — no importers; the View modal renders `PanelEditorQueryBuilder`. It referenced a stylesheet class that no longer exists. Behaviour is unchanged for every registered kind. The one visible difference: a panel whose kind this build can't render now says so, instead of rendering a header above an empty body. #### Issues Closed Closes SigNoz/pulse-pod#279 #### Additional Information - **Read it commit by commit** — each is one theme (declare / request path / axis / builder mode / analytics / registry), and the diff is mostly deletions once the declarations are in place. - The legacy enum still appears in ~28 V2 files, all of it *translation at a boundary* rather than a decision: the V1 `Query` pivot (`mapCompositeQueryFromQuery` writes `panelType` into `ICompositeMetricQuery`), URL params (`graphType` / `panelTypes` are a serialised contract), the shared `QueryBuilderV2` provider (where `panelType` is provider state read by its subcomponents), and analytics. A follow-up will quarantine those into a single boundary module with a lint rule keeping them there. - The last commit deletes `resolveQueryCapabilities`, added earlier in this branch: it existed only to absorb a missing definition, which the registry no longer produces.
…12767) #### Description - Adds a `subscription` domain: `POST`, `PUT`, and `GET /api/v1/subscriptions`, wired with `CheckResources` + `ResourceDef`s on the `subscription` metaresource (`create`, `list` + `update`, `read`). Community gets a noop implementation; enterprise talks to Zeus. - Migration `125_add_subscription_tuples` backfills the admin subscription tuples for existing organizations. - The legacy `/api/v1/checkout`, `/api/v1/billing`, and `/api/v1/portal` routes are untouched; they are deleted once the frontend has moved. #### Additional Information Part of SigNoz/platform-pod#3091.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )