[pull] main from SigNoz:main - #948
Merged
Merged
Conversation
#12757) #### Description - Fixes the issue where applying filter for value / filter out (also group by and replace filter) from the log details drawer was removing the added columns from the table. - As part of this fix, we rename `id` and `name` fields in explorerTabChange input type. Now it reads `viewName` and `viewKey` and avoids confusion - Now consumers of explorerTabChange need to send viewName and viewKey only if needed. As now this is an optional field #### Screenshots/Recording Before https://github.com/user-attachments/assets/4c6145e3-4979-4386-9230-f74eb00721c8 After https://github.com/user-attachments/assets/52bc3083-40a2-4345-aebd-63770882b06c #### Issues closed by this PR Closes SigNoz/engineering-pod#6012 #### Additional Information - same issue was present in the old drawer (group by, replace filter) and the metrics explorer detail (passed the metric name)..both fixed here. metrics never surfaced as a bug since it opens in time series with no columns to collapse - filter for/out in the old drawer was never affected, it uses a different add to query path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 馃挅 Please sponsor : )