[pull] main from SigNoz:main - #944
Merged
Merged
Conversation
#### Description Registers a new per-user preference `log_details_pinned_attributes` in `pkg/types/preferencetypes`, following the same shape as the existing `span_details_pinned_attributes` (trace-details pin feature, #11092).
…efix (#12093) #### Description - Adds `GET|POST /prometheus/api/v1/query_range` and `/prometheus/api/v1/query` (`pkg/prometheus/promapi`), following the Prometheus HTTP API contract: float-unix or RFC3339 times, float-seconds or duration-string durations, the `{status, data, errorType, error, warnings, infos}` envelope with Prometheus' status codes, and the 11,000-point cap. - The `/prometheus` prefix works as a drop-in Prometheus base URL: Grafana's Prometheus data source, promtool, and the PromQL compliance tester append `/api/v1/*` to a base URL, so they can point at SigNoz unmodified. Same layout as Mimir/Cortex. - Wired through `signoz.Handlers` (`prometheus.Handler` interface, constructed in `NewHandlers`) like the other domain handlers. - Range queries serve through the `RangeExecutor` capability when the provider has it, so a clickhousev2-serving deployment transpiles through these endpoints too. - New `promapiconformance` integration suite: the frozen promqltest corpus replayed against these endpoints with `prometheus::provider: clickhousev2` — the two paths nothing else exercises (v2 as serving provider, and this API surface). Instant cases go through `/query` with a real `time` parameter. The `instant-coarse` corpus variants are skipped — they exist only to encode instant evals as coarse ranges for the v5 API, and their transpiled coarse-step serving is already covered and ledgered by promqlconformance's clickhousev2 leg — so this suite asserts zero divergences with no ledger of its own. - Purely additive: the existing `GET /api/v1/query_range` and `GET /api/v1/query` handlers are untouched. `openapi.yml` is generated and these mux-registered routes are outside the generator, so their documentation is the upstream Prometheus API contract they follow. #### Additional Information Final slice of the clickhouseprometheusv2 stack (#12323, #12324, #12325 — merged). Legacy endpoint removal, if ever, is a separate change after usage drains.
…amed transpiled units (#12728) ## Description <img width="1420" height="516" alt="image" src="https://github.com/user-attachments/assets/cc536314-71d2-4750-b394-d53c41ac7d91" /> the un-needed query contributed to this data read to query service, which had a purpose in earlier dev cycle but not longer needed.
## Description - The promql engine traces every evaluation through the global tracer provider under an unnamed scope: `promqlExec`, `promqlPrepare`, `promqlExecQueue`, and one `promqlInnerEval eval *promql.<Node>` span per AST node per query. These didn't find much useful as the bottleneck is usually the CH so we remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )