[pull] main from SigNoz:main - #941
Merged
Merged
Conversation
) #### Description - The `shows PermissionDeniedCallout in Keys tab when list-keys permission is denied` test intermittently failed in CI: the `fireEvent.click` on the Keys tab races with the nuqs testing adapter, which can abort the queued `tab=keys` URL update mid-flight, leaving the drawer stuck on the Overview tab. - Since the tab is URL state, the test now lands directly on the Keys tab via initial search params (`{ account: 'sa-1', tab: 'keys' }`), avoiding the userEvent/click interaction altogether. The click-to-Keys flow remains covered in `ServiceAccountDrawer.test.tsx`. #### Issues closed by this PR closes SigNoz/platform-pod#3053
<!--A few plain bullets saying what changed and why, for a reviewer skimming it - not a wall of text, not a restatement of the diff, not generated boilerplate.--> #### Description - traces explorer was crashing on some shared/legacy links...the query builder reads `builder.queryFormulas` and `queryTraceOperator` directly and these can be missing from a partial compositeQuery (old saved view, shared link, older release) - fixed it where the query enters state from the url param, defaulting the arrays to `[]`...this way every consumer gets `[]` and not undefined, not just the component that crashed - also default them in `prepareQueryBuilderData` so any query loaded into the provider is normalized - optional chained the reads in `QueryBuilderV2` as a render level safety net - added a test that a partial query (missing these arrays) renders without crashing <!--Reference issues using `Closes #issue-number` to enable automatic closure on merge. --> #### Issues closed by this PR Closes SigNoz/engineering-pod#5949 Closes SigNoz/engineering-pod#4320 Closes SigNoz/engineering-pod#3335 Closes SigNoz/engineering-pod#4314 <!--If applicable, include screenshots or screen recordings that clearly show the behavior before the change and the result after the change. --> #### Screenshots / Screen Recordings [Test URL Link](https://app.us.staging.signoz.cloud/traces-explorer?relativeTime=1h&compositeQuery=%257B%2522queryType%2522%253A%2522builder%2522%252C%2522builder%2522%253A%257B%2522queryData%2522%253A%255B%257B%2522dataSource%2522%253A%2522logs%2522%252C%2522queryName%2522%253A%2522A%2522%252C%2522aggregateOperator%2522%253A%2522noop%2522%252C%2522aggregateAttribute%2522%253A%257B%2522id%2522%253A%2522----%2522%252C%2522dataType%2522%253A%2522%2522%252C%2522key%2522%253A%2522%2522%252C%2522type%2522%253A%2522%2522%257D%252C%2522timeAggregation%2522%253A%2522rate%2522%252C%2522spaceAggregation%2522%253A%2522sum%2522%252C%2522filter%2522%253A%257B%2522expression%2522%253A%2522service.name%2520%253D%2520%27midtier-api-production%27%2520AND%2520severity_text%2520%253D%2520%27ERROR%27%2522%257D%252C%2522aggregations%2522%253A%255B%257B%2522expression%2522%253A%2522count%28%29%2522%257D%255D%252C%2522functions%2522%253A%255B%255D%252C%2522filters%2522%253A%257B%2522items%2522%253A%255B%255D%252C%2522op%2522%253A%2522AND%2522%257D%252C%2522expression%2522%253A%2522A%2522%252C%2522disabled%2522%253Afalse%252C%2522stepInterval%2522%253Anull%252C%2522having%2522%253A%257B%2522expression%2522%253A%2522%2522%257D%252C%2522limit%2522%253Anull%252C%2522orderBy%2522%253A%255B%255D%252C%2522groupBy%2522%253A%255B%255D%252C%2522legend%2522%253A%2522%2522%252C%2522reduceTo%2522%253A%2522avg%2522%252C%2522source%2522%253A%2522%2522%257D%255D%257D%252C%2522promql%2522%253A%255B%257B%2522name%2522%253A%2522A%2522%252C%2522query%2522%253A%2522%2522%252C%2522legend%2522%253A%2522%2522%252C%2522disabled%2522%253Afalse%257D%255D%252C%2522clickhouse_sql%2522%253A%255B%257B%2522name%2522%253A%2522A%2522%252C%2522legend%2522%253A%2522%2522%252C%2522disabled%2522%253Afalse%252C%2522query%2522%253A%2522%2522%257D%255D%252C%2522id%2522%253A%25225d398425-eb7e-41e4-990a-de9375baf74a%2522%252C%2522unit%2522%253A%2522%2522%257D&options=%7B%22selectColumns%22%3A%5B%7B%22name%22%3A%22timestamp%22%2C%22signal%22%3A%22logs%22%2C%22fieldContext%22%3A%22log%22%2C%22fieldDataType%22%3A%22%22%2C%22isIndexed%22%3Afalse%7D%2C%7B%22name%22%3A%22body%22%2C%22signal%22%3A%22logs%22%2C%22fieldContext%22%3A%22log%22%2C%22fieldDataType%22%3A%22%22%2C%22isIndexed%22%3Afalse%7D%5D%2C%22maxLines%22%3A1%2C%22format%22%3A%22raw%22%2C%22fontSize%22%3A%22small%22%7D) Before: <img width="3452" height="1780" alt="image" src="https://github.com/user-attachments/assets/4f1e871f-6063-4aeb-93b2-a902d57abdb9" /> After: <img width="3002" height="1648" alt="image" src="https://github.com/user-attachments/assets/645411d8-3462-4701-9694-1ea743ac2e17" /> <!--Anything reviewers should keep in mind while reviewing --> #### Additional Information Pager: https://signoz-1.pagerduty.com/incidents/Q3YCF0KG3OYSYX Sentry:https://signoz-io.sentry.io/issues/7498496470/?referrer=pagerduty_integration¬ification_uuid=5cd4dc50-634b-416f-ab84-9540706c43aa <!--Please delete paragraphs that you did not use before submitting.-->
#### Description - Deployment host routes (`GET`/`PUT /api/v2/zeus/hosts`) now use `CheckResources` + `ResourceDef` instead of the coarse `ViewAccess`/`AdminAccess` gates — per-resource FGA checks on enterprise, role gate on community. - New `deployment-host` metaresource kind with `list`/`update` verbs — the GET returns the deployment's host collection and the PUT upserts the single editable host. Admins get `list`+`update`, editors and viewers get `list`, preserving current behavior. - Migration `118_add_deployment_host_tuples` backfills the tuples for existing organizations and re-syncs the stored managed-role transaction groups; new organizations get both from the registry at bootstrap. - Regenerated OpenAPI spec and transaction-groups schema: the operations advertise `deployment-host:list`/`deployment-host:update` scopes instead of `VIEWER`/`ADMIN`. - Added `deploymenthost/01_authz.py` covering managed-role gating, custom-role `list`/`update` grants, and rejection of verbs the resource does not support. #### Issues closed by this PR Closes SigNoz/platform-pod#2652
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )