[pull] main from SigNoz:main - #938
Merged
Merged
Conversation
#### Description * adds `ai_observability` to saved view for ai explorer <!--Reference issues using `Closes #issue-number` to enable automatic closure on merge. --> #### Issues closed by this PR Closes SigNoz/engineering-pod#5955
<!--A few plain bullets saying what changed and why, for a reviewer skimming it - not a wall of text, not a restatement of the diff, not generated boilerplate.--> #### Description - forks the Traces Explorer into the AI Observability Explorer tab, replacing the "Explorer coming soon" placeholder. All four views land: list, trace, timeseries and table. - the copied code is kept identical to the traces original on purpose — same variable names, same `LOCALSTORAGE` keys, same analytics events, same `DataSource.TRACES`. Only the folder layout differs. Divergence (GenAI columns, AI query surface) comes in follow-ups, so this stays a clean base to diff against. - shared modules are imported, not duplicated: `TracesExplorer/TracesTable`, `TracesExplorer/Controls`, `TracesExplorer/explorerUtils`, `TracesExplorer/ListView/utils` and `pages/TracesExplorer/aiActions`. - both table views therefore use the shared TanStack table, so the AI explorer starts out with resizable/reorderable columns rather than the old antd `ResizeTable`. <!--Reference issues using `Closes #issue-number` to enable automatic closure on merge. --> #### Issues closed by this PR Closes - https://github.com/orgs/SigNoz/projects/39/views/20?pane=issue&itemId=223107878&issue=SigNoz%7Cengineering-pod%7C5843 <!--If applicable, include screenshots or screen recordings that clearly show the behavior before the change and the result after the change. --> #### Screenshots / Screen Recordings https://github.com/user-attachments/assets/6f3bb336-f555-4345-aeca-ba061401f5af <!--Anything reviewers should keep in mind while reviewing --> #### Additional Information - **Stacked on #12672.** The first three commits are that PR cherry-picked, since the trace view fork depends on its `FieldCell` trace_id handling and the optional `columnStorageKey` / `respectColumnOrder` props. Review only the last commit here; rebase drops the rest once #12672 lands. - `LLMObservability.test.tsx` now stubs `Explorer` the same way it already stubs `DashboardContainer` — the real toolbar calls `useNavigationType`, which needs a data router that integration test does not mount. Co-authored-by: Gaurav Tewari <tewarig@users.noreply.github.com>
## Pull Request --- ### 📄 Summary follow-up for #12027. Span-list trace-aggregate filtering ships in #12122. Adds `scalar` and `time_series` request types to `builder_ai_query`. The `trace.` prefix selects the aggregation domain: trace aggregates use a native CTE pipeline, while span aggregates delegate to the standard traces builder with the qualification gate applied. Trace-level filters qualify entire traces across both domains using the standard filter pipeline. Grouping, `HAVING`, ordering, and limits match the traces builder, including whole-window ranking for grouped time series and top-N limits for scalar queries. `count(trace.trace_id)` counts every AI trace, matching the trace list; token aggregates average over traces that have token data (standard `NULL` semantics, same as span-attribute aggregations elsewhere). Includes SQL golden tests, rewrite unit tests, and integration coverage for both domains, qualification, grouping, limits, bucketing, variables, and targeted `400` errors. #### Issues closed by this PR Fixes SigNoz/engineering-pod#5602 Fixes SigNoz/engineering-pod#5603 --- ### ✅ Change Type _Select all that apply_ - [x] ✨ Feature - [ ] 🐛 Bug fix - [ ] ♻️ Refactor - [ ] 🛠️ Infra / Tooling - [ ] 🧪 Test-only --- ### 🧪 Testing Strategy > How was this change validated? - Tests added/updated: ✅ - Manual verification: - Edge cases covered: --- ###⚠️ Risk & Impact Assessment > What could break? How do we recover? - Blast radius: None - Potential regressions: - Rollback plan: --- ### 📋 Checklist - [x] Tests added or explicitly not required - [x] Manually tested - [ ] Breaking changes documented - [ ] Backward compatibility considered --- ## 👀 Notes for Reviewers Still in testing phase ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )