[pull] main from SigNoz:main - #935
Merged
Merged
Conversation
<!--A few plain bullets saying what changed and why, for a reviewer skimming it - not a wall of text, not a restatement of the diff, not generated boilerplate.--> #### Description This PR fixes the Prev and next buttons shifting down on click due to loader . - cause was recent [icon migration](#11222) away from antd which restyled the loader. - removed the loader on these buttons. they already disable while loading, so the spinner was redundant and it was what caused the shift - moved the buttons from antd (`Button`/`Flex`/`Spin`) to the `@signozhq/ui` button - removed the styled-components file, layout is a css module now <!--Reference issues using `Closes #issue-number` to enable automatic closure on merge. --> #### Issues closed by this PR SigNoz/engineering-pod#5942 <!--If applicable, include screenshots or screen recordings that clearly show the behavior before the change and the result after the change. --> #### Screenshots / Screen Recordings Before https://github.com/user-attachments/assets/db76270b-60f3-441f-adad-96abec9dd04b After https://github.com/user-attachments/assets/bb844652-b274-4849-9d49-485080308484
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 馃挅 Please sponsor : )