[pull] main from SigNoz:main - #933
Merged
Merged
Conversation
<!--A few plain bullets saying what changed and why, for a reviewer skimming it - not a wall of text, not a restatement of the diff, not generated boilerplate.--> #### Description - Lets users add a free-typed column in the logs explorer "Edit columns" panel, even if the key is not in the fields suggestions (e.g. nested body json paths). Logs only. - Shows the typed value as an addable option when it is not already a suggestion or added. Exact, case-insensitive name match. - Value shows via the existing body-first lookup. Nothing new is sent to the backend for logs. - Changed the column key separator from `.` to `:` so a typed dotted name cannot clash with a context key (e.g. `resource.severity_text`). Old saved keys self-heal, no migration. <!--Reference issues using `Closes #issue-number` to enable automatic closure on merge. --> #### Issues closed by this PR Closes SigNoz/engineering-pod#5877 <!--If applicable, include screenshots or screen recordings that clearly show the behavior before the change and the result after the change. --> #### Screenshots / Screen Recordings https://github.com/user-attachments/assets/0e91bb00-4be5-4dc7-ad3e-0e005ee6eb6b <!--Anything reviewers should keep in mind while reviewing --> #### Additional Information Value needs `use_json_body` on for nested body paths, else the cell is empty. Array paths and a leading `body.` dont resolve on the frontend for now. <!--Please delete paragraphs that you did not use before submitting.-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 馃挅 Please sponsor : )