[pull] main from SigNoz:main - #929
Merged
Merged
Conversation
…ation datasources (#12595) #### Description - Adds Grok Build, GitHub Copilot, Serilog, and GCP Integration to the onboarding data source picker. - Adds a runtime step under AWS Lambda → Traces, so the new Go SDK guide is reachable alongside the auto-instrumentation layers. - New `github-copilot.svg`; the other three reuse existing logos (`grok`, `dotnet`, `gcp`). #### Issues closed by this PR Closes SigNoz/signoz.io#3999 Closes SigNoz/signoz.io#3982 Closes SigNoz/signoz.io#3972 Closes SigNoz/signoz.io#3947 Closes SigNoz/signoz.io#3806
…outside total (#12453) ## Pull Request --- ### 📄 Summary > Why does this change exist? > What problem does it solve, and why is this the right approach? This PR fixes the following issues: - page not resetting to 1 when switch - bug was only detected/present when coming from deep link - page not resetting to 1 when page produces a offset higher than total - you had to switch to hosts to be able to see data again #### Screenshots / Screen Recordings (if applicable) > Include screenshots or screen recordings that clearly show the behavior before the change and the result after the change. This helps reviewers quickly understand the impact and verify the update. Before: Issue with page not reseting to 1 when changing category (after refresh): https://github.com/user-attachments/assets/00872b38-1263-43c1-8322-64d31ee1ee6a Issue with page outside the offset: https://github.com/user-attachments/assets/5194fb2e-5af3-491b-baf7-b4aa3a330c83 --- After: Issue with page not reseting to 1 when changing category (after refresh): https://github.com/user-attachments/assets/545e5914-c26f-4189-b15a-dc399bdee28b Issue with page outside the offset: https://github.com/user-attachments/assets/1b93d162-22a3-41c8-802e-aa2aa6012db9 #### Issues closed by this PR > Reference issues using `Closes #issue-number` to enable automatic closure on merge. Closes SigNoz/pulse-pod#208 --- ### ✅ Change Type _Select all that apply_ - [ ] ✨ Feature - [x] 🐛 Bug fix - [ ] ♻️ Refactor - [ ] 🛠️ Infra / Tooling - [ ] 🧪 Test-only --- ### 🐛 Bug Context > Required if this PR fixes a bug Both issues are caused after the refactor to the new table component and after joining the categories into single component (without unmount/mount when switching categories). #### Root Cause > What caused the issue? > Regression, faulty assumption, edge case, refactor, etc. Lack of reset the page to 1, and no proper way to detect and reset page to 1 when outside the boundaries. #### Fix Strategy > How does this PR address the root cause? Reset to page 1 after switch category and also include hook on tanstack to ensure we reset page to last when outside the params. --- ### 🧪 Testing Strategy > How was this change validated? - Tests added/updated: Yes - Manual verification: Yes - Edge cases covered: - --- ###⚠️ Risk & Impact Assessment > What could break? How do we recover? - Blast radius: Infrastructure Monitoring - Potential regressions: - - Rollback plan: Open a new PR to fix the issue --- ### 📝 Changelog > Fill only if this affects users, APIs, UI, or documented behavior > Use **N/A** for internal or non-user-facing changes | Field | Value | |------|-------| | Deployment Type | Cloud / OSS / Enterprise | | Change Type | Bug Fix | | Description | We fixed two issues around pagination inside Infrastructure Monitoring causing the page not resetting to 1 after switch category or when offset is higher than total amount of items. | --- ### 📋 Checklist - [x] Tests added or explicitly not required - [x] Manually tested - [ ] Breaking changes documented - [ ] Backward compatibility considered
…#12427) ## Pull Request --- ### 📄 Summary > Why does this change exist? > What problem does it solve, and why is this the right approach? These are pending code that was supposed to be deleted after Infrastructure Monitoring & Alert History adopt the QBv5. #### Issues closed by this PR > Reference issues using `Closes #issue-number` to enable automatic closure on merge. Closes SigNoz/engineering-pod#5117 Closes SigNoz/engineering-pod#5116 --- ### ✅ Change Type _Select all that apply_ - [ ] ✨ Feature - [ ] 🐛 Bug fix - [x] ♻️ Refactor - [ ] 🛠️ Infra / Tooling - [ ] 🧪 Test-only --- ### 🧪 Testing Strategy > How was this change validated? - Tests added/updated: Yes - Manual verification: - - Edge cases covered: - --- ###⚠️ Risk & Impact Assessment > What could break? How do we recover? - Blast radius: Query Builder - Potential regressions: Deleting more code than needed - Rollback plan: Revert the deletion. --- ### 📝 Changelog > Fill only if this affects users, APIs, UI, or documented behavior > Use **N/A** for internal or non-user-facing changes | Field | Value | |------|-------| | Deployment Type | Cloud / OSS / Enterprise | | Change Type | Maintenance | | Description | N/A | --- ### 📋 Checklist - [x] Tests added or explicitly not required - [x] Manually tested - [ ] Breaking changes documented - [ ] Backward compatibility considered
#### Description - Auth domain routes (`/api/v2/auth_domains`) now use `CheckResources` + `ResourceDef` instead of the coarse `AdminAccess` gate — per-resource FGA checks on enterprise, admin role gate on community. - Create and update also check `attach` on the roles the request's `roleMapping` will grant at SSO login (mapped roles + default role, `signoz-viewer` when unset, `role:*` when `useRoleAttribute` is on); update additionally checks `detach` on the roles the stored mapping was granting, since a `PUT` replaces the mapping. - Migration `117_add_auth_domain_tuples` backfills the admin `auth-domain` tuples for existing organizations and re-syncs the stored managed-role transaction groups; new organizations get both from the registry at bootstrap. - Regenerated OpenAPI spec: the auth-domain operations advertise `auth-domain:*` and `role:attach`/`role:detach` scopes instead of `ADMIN`. - Added `callbackauthn/05_authz.py` covering managed-role gating, custom-role wildcard/instance grants, and the role-mapping attach/detach checks. #### Issues closed by this PR Closes SigNoz/platform-pod#2649
#### Description
- Removes the deprecated `POST /api/v1/service_accounts/{id}/roles` and
`DELETE /api/v1/service_accounts/{id}/roles/{rid}` routes, their HTTP
handlers, and the `DeprecatedPostableServiceAccountRole` type, now that
all consumers use `/api/v1/service_account_roles`.
- Keeps the `GET /api/v1/service_accounts/{id}/roles` listing endpoint.
- Regenerates `docs/api/openapi.yml` and the frontend client.
#### Issues closed by this PR
Closes SigNoz/platform-pod#2919
#### Additional Information
- Final step of the migration; the frontend (#12589) and
integration-test (#12590) consumer moves are already merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )