[pull] develop from mermaid-js:develop - #223
Merged
Merged
Conversation
Adds rendering coverage for syntax the e2e suite does not currently exercise. sequenceDiagram-central-connections.spec.ts (37 tests) Central-connection message syntax: the ()->>() family plus its REVERSE and DUAL forms, in both directions, with and without autonumber. sequenceDiagram-participant-types.spec.ts (30 tests) The participant type matrix (actor, boundary, control, entity, database, collections, queue) combined with notes in all positions, loops, alternative flows, parallel blocks, self-references, and long or wrapped text. mindmap.spec.ts (3 tests) A formatted label with a linebreak, wrapping and emojis; all shapes with an mdi:fire icon; and a label containing the char sequence "graph". All 87 tests across the three files pass locally against develop.
The e2e suite defines rendering snapshots as .mmd files under e2e/diagrams/<group>/, which e2e/rendering/mmd-snapshots.spec.ts discovers and registers automatically. This change moves the coverage added here over to that pattern instead of hand-written spec files. - Drop sequenceDiagram-participant-types.spec.ts entirely: all 30 tests already exist as fixtures in e2e/diagrams/sequence/. - Drop sequenceDiagram-central-connections.spec.ts: 23 of its 37 tests were already covered by existing fixtures; the 14 genuinely new self-reference cases are added as .mmd files. - Add the two participant-type scenarios that extended an existing fixture with central connections under their own names, so the existing baselines are left untouched. - Drop the two mindmap tests that duplicate existing fixtures. The mdi:fire shape test stays in mindmap.spec.ts because it asserts via the shouldHaveRoot validation callback, which the generic .mmd runner cannot express. Net effect: 16 new fixtures, no new spec files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…dmap-coverage test(e2e): expand sequence diagram and mindmap rendering coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )