[pull] master from mattermost:master - #959
Merged
Merged
Conversation
* E2E/Cypress: re-hover until the emoji picker preview settles clickEmojiInEmojiPicker hovered an emoji once and then waited on the picker preview to name it. Loading recent or custom emojis re-renders the picker and resets its cursor to the first emoji, so a hover that landed just before that update was discarded and the retrying assertion could never recover. reactions_spec.js hit this in CI on MM-T2192, which then took the two tests after it down with it: the test failed before its own uiCloseRHS(), and the RHS it left open covers the center channel the rest of the file drives. Retry the hover alongside the assertion, and close the RHS before each test in reactions_spec.js so a single failure no longer cascades. Co-authored-by: Cursor <cursoragent@cursor.com> * E2E/Cypress: hover before waiting on emoji picker preview clickEmojiInEmojiPicker asserted emoji_picker_preview exists before hovering, but that testid is only rendered after an emoji is selected. MM-T2186 searches first, so the helper timed out. Hover each waitUntil retry and use Cypress.$ so a missing node is falsy instead of findAllByTestId throwing out of the loop. Co-authored-by: mattermost-code <matty-code@mattermost.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
…bar placement, labels, and ordering (#38217) * docs: hide cloud-supported-integrations snippet from the Overview sidebar This file is a snippet include (an :orphan: :nosearch: fragment in Sphinx), imported by Cloud Dedicated and Cloud Shared. It was listed in the Cloud group of the Overview sidebar, so it also rendered as a standalone page with a raw filename heading and a bare list of links. Move it into OVERVIEW_HIDDEN alongside the common-esr-support partials. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: move Corporate Directory Integration into the Administration Guide The page was listed in Overview > Subscription Overview > Cloud purely because its file sat in product-overview/. Sphinx navigated it only from administration-guide/manage/admin/user-provisioning.rst's toctree and from no Overview toctree at all. Move the file to administration-guide/onboard/ and make it the landing page of Onboard > SSO & Identity, which had none and whose nine pages it surveys. Update the two inbound links, retarget the /about/ and /overview/auth redirects, and add a redirect from the pre-move URL. Also fix the PDF book spines, which still listed it under Product Overview. Separately, drop common-converting-oauth-to-openidconnect from the same group: it is an :orphan: :nosearch: snippet include, and with no title frontmatter it rendered in the sidebar as "Common Converting Oauth To Openidconnect". Co-authored-by: Cursor <cursoragent@cursor.com> * docs: nest Source Available License under Business & Licensing On the old site faq-mattermost-source-available-license lived in faq-license.rst's own toctree, so it rendered as a child of Business & Licensing. The migration flattened that level and made the two siblings under Frequently Asked Questions. Restore the nesting with an inline sub-group, matching the Cloud sub-group pattern already used in OVERVIEW_GROUPS. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: shorten the General and Enterprise FAQ sidebar labels Sphinx's FAQ toctree used short nav labels ("General", "Enterprise") while the pages kept longer titles. The migration used titles for both, so the sidebar carried "General Mattermost" and "Enterprise Edition". Restore the short labels via sidebar_label, leaving the page titles as they are. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: restore the remaining short FAQ sidebar labels Same migration gap as the General and Enterprise labels: Sphinx's toctrees listed these as "Federal Procurement" and "Source Available License" while the pages carried longer titles. Set sidebar_label on both; page titles are unchanged. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: order the Use Case Guide sidebar to match its landing page The section has no manual grouping override, so buildCategory sorted it by filename. devops-collaboration.mdx is titled "Real-Time DevSecOps Collaboration", so it sorted first while the landing page lists it sixth. Set sidebar_position on all eight pages. Positions are needed on every page rather than just the odd one out, because the sort key is [position || 9999, filename] — a page with a position always sorts ahead of one without. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: narrow the Corporate Directory Integration redirect changes Drop the PDF spine edits; the PDF pipeline is being handled separately. Remove the /product-overview/corporate-directory-integration redirect. That path only ever existed on the revamp preview, which never served customers, so there is no inbound traffic to preserve. Point the legacy /onboard/common-converting-oauth-to-openidconnect redirect at convert-oauth20-service-providers-to-openidconnect, the page that includes the snippet, rather than at the snippet fragment itself. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: drop legacy redirects that resolved to snippet fragments Sphinx generated a redirect for every source file, including the :nosearch: include fragments that only exist to be pulled into a real page. Those fragments should never have had public URLs, so preserving inbound paths to them preserves a mistake: the reader lands on a bare list with no title and no way back into the navigation. Remove the four such redirects, covering the cloud-supported-integrations, common-esr-support (plus -upgrade and -rst) and common-converting-oauth-to-openidconnect fragments. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: reorganise the Deployment Guide information architecture Restructure the guide around the order a reader actually works in — evaluate, pick a scenario, plan, prepare, install, secure, scale, back up, operate, troubleshoot — so the sidebar teaches the deployment process rather than mirroring the directory layout it was generated from. - Consolidate air-gapped content into air-gapped-operations/. The scenario page had grown into a second, drifting copy of the registry-mirroring procedure; it is now a short architectural framing that links to the runbook. The Local Documentation steps move with it, rewritten for the current Node build rather than the retired Sphinx toolchain. - Flatten reference-architecture/ (28 files). The nav category was dissolved earlier but its URL segment and hidden index page were left behind. - Move the PostgreSQL and FIPS migration pages to the Administration Guide, restoring the placement Sphinx uses and giving fips-migration a sidebar home for the first time. - List desktop and mobile troubleshooting only under the central troubleshooting hub, with prominent links from each platform landing page, so prev/next pagination is not split across two locations. - Normalise labels to sentence case via title rather than sidebar_label, so sidebar entries and page headings stop disagreeing. - Rewrite the guide index, which was a verbatim Sphinx port linking to an orphaned page and omitting 7 of 13 sidebar groups. DEPLOYMENT_HIDDEN is now empty and all 87 pages are reachable from the sidebar. Redirects are added for the eight reference-architecture URLs that the live Sphinx site still serves; they had no entry in active-redirects.json because their paths were previously identity-mapped, so flattening would have 404'd them on cutover. The deployment-guide and administration-guide PDF book manifests are resynced — the latter was already carrying 20 dangling entries from the earlier scale migration. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: restore Title Case labels in the Deployment Guide Revert the sentence-case conversion of 22 titles and sidebar labels, and update the six link texts that referenced them, so the Deployment Guide keeps Title Case for page titles and sidebar entries. Rewordings from the same pass are unaffected: the parenthetical nav prefixes, the three-way architecture rename, the digit grouping in the scale-to-* labels, and the "Partner and marketplace deployment options" rename all stand. Note that docs/styles/Mattermost/Headings.yml asks for sentence case in headings. It only scopes to Markdown headings, not frontmatter, so it does not flag these — but the two conventions now disagree for any page whose H1 comes from its frontmatter title. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: rename the server group to Deploy the Server and Title Case sidebar labels "Install the server" understated what the group covers and clashed with its own pages: all nine are titled "Deploy Mattermost ...", and they use "install" for a narrower step within them, alongside database setup, configuration, and startup. Also Title Case the eleven Deployment Guide generator labels. These live in the sidebar generator rather than frontmatter, so the earlier Title Case revert never reached them, leaving categories like "Desktop app deployment" opening a page titled "Desktop App Deployment". Every other section's generator labels were already Title Case. The two-tier grammar is deliberate and preserved: imperative verbs for the sequential spine (Plan, Prepare, Deploy the Server, Secure Your Deployment, Scale, Back Up and Recover, Troubleshoot Deployments) and nouns for the per-product sections (Calls, Desktop App, Mobile App Deployment). Co-authored-by: Cursor <cursoragent@cursor.com> * docs: restore the Deployment Solution Programs title Revert the Phase 6 rename. "Partner and marketplace deployment options" promised marketplace content the page does not have — it covers the partner recognition programme and its Community, Registered, and Certified tiers. The clearer one-line description on the Plan landing page is kept, since that is where the ambiguity the rename was chasing is best resolved. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: restore Deployment Architecture at Scale, unlist a partial, move SAML encryption Three unrelated fixes to the Deployment Guide reorganisation: - Restore the "Deployment Architecture at Scale" title on scale/server-architecture. It no longer collides with anything, since the page formerly called "Deployment Architecture" is now "Size your deployment". - Stop listing common-configure-mattermost-for-enterprise-search in the sidebar. It is an MDX partial imported by both elasticsearch-setup and opensearch-setup, so its content already renders inside them; the Phase 4 grouping added it a third time as a context-free standalone entry. It keeps its file and URL because admin-onboarding-tasks deep-links to its limitations anchor. Handled with a new DEPLOYMENT_SNIPPETS set rather than DEPLOYMENT_HIDDEN, so the latter stays empty and keeps its meaning as a reachability signal. - Move the SAML encryption method list off the deployment-side encryption-options page into the SAML settings reference, beside the Encrypt setting it describes. Nine Administration Guide links already pointed into it, which is what it is for; encryption-options keeps a cross-link. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: fix copy errors in the deployment and security guides - Hyphenate "full-text message search" in the enterprise search description. - Drop a stray "the" before the desktop release-history link. - Remove a doubled closing parenthesis after the out-of-band link in the CMMC compliance guide. - Correct "availabilty" and "availaiblity" in the application architecture page. - Comma-separate every displayed user count across the scale pages. Applied to all nine rather than only the four reported, since formatting a subset would have left them inconsistent with their siblings in the same list. URLs and filenames keep their unpunctuated form. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: restore a collapsed note list and fix a high availability link The RST-to-MDX conversion joined three note items onto one line in the authentication settings, so they rendered as a paragraph. The command resilience bullet also pointed both of its links at the scaling guide. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: rename and reorder the Security Guide, and remove four pages Rename "Security & Compliance" to "Security Guide". It was the only top-level entry not following the "* Guide" pattern, and "Security Guide" is what Sphinx calls the section. Add a sidebar ordering override. The section had none, so it rendered alphabetically and led with the regulatory pages ahead of the hardening guidance most readers arrive for. It now runs Secure Mattermost, Zero Trust, Mobile Security, then CMMC/FINRA/HIPAA grouped under Compliance Frameworks. Remove the three pages under compliance-frameworks/. They have no Sphinx counterpart and are not publishable as written: - Internal planning artifacts leaked into the prose. Three bullets read "preserved at parent level pending Phase 2 re-organization", two pages cite "Audit Log Reference (Phase 2)" as a source, and the index carries a note addressed to authors rather than readers. - The DISA STIG control mapping is wrong. Four SRG identifiers are each mapped to two different requirements (SRG-APP-000033, -000148, -000164 and -000516), and SRG-APP-000068 is labelled account lockout when it is the DoD consent banner requirement. These are identifiers an accreditor would copy into an authorization package. - Both pages assert authorization posture and roadmap commitments (status="roadmap", "Not on roadmap") that belong on the Trust Portal, not in docs. Remove dependency-vulnerability-analysis as unmaintained. It is a point-in-time snapshot scoped to "our latest release" that still promises an upgrade in v11.4. Repoint the persona landing pages that linked to the removed content. That also clears four duplicate card targets on the developer page and returns its grids to the 3/6/3 shape the other persona pages use. Add redirects for the removed URLs and drop the deleted page from the PDF spine. active-redirects.json is maintained by hand now, since the input its generator reads never came across in the monorepo move, so correct its metadata and the config comment claiming it is regenerated. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: reorganise the Integrations Guide information architecture Lead with Plugins, then the catalogue. Plugins explains the delivery mechanism that the catalogue and every vendor page depend on, but it sat last in the guide while Popular Pre-Built Integrations sat first, so the two ends of one idea were as far apart as the section allows. Nest the vendor pages under the catalogue they belong to, split Microsoft and third-party to match the tables already on that page. The sidebar and the page were carving up the same nine pages on different lines: Zoom was third-party on the page but grouped with Microsoft in the sidebar, and M365 was Microsoft on the page but "Chat & Meeting Interop" in the sidebar. Within each group they are now alphabetical, which is the only order a reader scanning for a vendor name can predict. Flatten No-Code Automation and RESTful API to root entries. The former was a category holding a single page of the same name, and the latter sat under "Built-in Integrations" alongside Plugins — a label that fits neither, since custom plugins are the pro-code path and an API is not an integration. Removing that catch-all takes the section from four levels deep to three. Shorten the vendor sidebar labels. Seven of nine read "Connect X to Mattermost", so the vendor name was buried mid-string and wrapped in the sidebar. Sphinx overrode these to bare vendor names in its toctree and the override was lost in the migration; sidebar_label restores it without touching any H1. Also correct "Built-In" to "Built-in" to match the page's own headings. Add a "Mattermost-built plugins" section covering Channel Export, Legal Hold, Metrics, and User Survey. These are first-party plugins that add capabilities rather than connecting to an external system, so they do not belong in a catalogue of connectors, and the page had no third category for them. Sphinx listed them in the integrations toctree; a Docusaurus doc resolves to one sidebar position, so linking them from the page keeps them discoverable without giving them a second home. No page moves, so no redirects change. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: suppress MDX snippet includes with unlisted frontmatter Snippet includes were hidden from the sidebar in three different ways: two generator-side lists (OVERVIEW_HIDDEN, DEPLOYMENT_SNIPPETS), a HIDDEN-set entry, or not at all. The five Administration Guide partials were not hidden at all, so content already rendered inside Environment configuration settings and the SAML provider pages was also listed as separate sidebar pages. Converge on `unlisted: true`, which Docusaurus already honours by dropping a page from the sidebar, search, and sitemap while keeping its URL — needed because 10 pages deep-link the push notification anchors. The generator now reads it too, so the generated sidebar matches what production renders. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: restructure the Administration Guide sidebar around admin tasks The section read as six categories named after the repository's folders, with placement following where a file happened to live: monitoring pages split between "Manage" and "Scale", access control split between "Manage" and "Onboard", System Console settings split across three groups, and Comply and Upgrade in filename order. Reorganize into Configure, Onboard users, Manage, Monitor and troubleshoot, Comply, Upgrade. Monitoring gets its own category — 15 pages is too much to hide inside Manage, and "Scale" told a reader nothing about what was in it. Groups that predicted nothing ("Optional capabilities", "Content & product governance") are dissolved, and the two hub pages a reader now lands on when opening Configure and Onboard users move into those sections so their URLs match the nav. No page is deleted and only the two hub pages change URL; both redirect. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: align Administration Guide labels and hub pages with the sidebar Sidebar labels mixed title case and sentence case, and several repeated their parent group ("Configure SAML with Okta" under SAML, "Google Single Sign-On" under Single sign-on). Sentence-case the titles that were simply mis-cased, and add sidebar_label where the nav needs a shorter form than the page title. The five hub pages a reader now lands on when opening a category or group listed a different set of pages than the sidebar under them — configuration settings omitted search and listed Bleve as a System Console category, monitoring and performance listed surveys and product limits, and comply was missing custom terms of service. Rewrite each to match, and cross-link the two migration hubs so it's clear which one covers moving off Slack and which one covers moving off MySQL. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: redirect the 21 scale pages that moved to the deployment guide Capacity planning, high availability, enterprise search, and Redis moved from /administration-guide/scale/ to /deployment-guide/scale/ during the migration, but only the pre-migration /scale/ URLs were redirected. The published docs.mattermost.com URLs for those 21 pages — the ones in search results and in customers' bookmarks — currently 404. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: fix broken link to the Prometheus and Grafana guide The Calls monitoring page linked to the page under /deployment-guide/scale/, but it lives under /administration-guide/scale/ and is now listed in Monitor and troubleshoot. Reported by the build's broken-link check. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: trim sidebar generator comments to what code can't say Drop rationale prose that restates the data structures or duplicates the `unlisted: true` frontmatter, keeping only constraints a future reader would otherwise have to rediscover. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: fix admin guide page titles instead of masking them with sidebar labels Six pages had a sidebar label papering over a title that was itself wrong: mis-cased, gerund where siblings are imperative, padded with "Mattermost"/ "guide", or (cloud-data-export) describing only half of what the page covers. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: order the End User Guide sidebar by reader journey Access, Workflow Automation, Project Management, and Preferences had no ordering override, so they fell through to alphabetical-by-filename and lost the sequence their own landing pages describe. Curate all four, restore the notification pages as children of the hub that explains them, and fix the labels and placements that alphabetical order made ambiguous. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: use the standard "license" spelling on the server maintenance page One bullet read "Install a license key ... Apply a licence", contradicting itself and the surrounding pages. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: give the Deployment Guide one starting point The Plan landing page had drifted into a second entry point that contradicted the guide index: it linked to Prepare and Install pages instead of its own children, carried a stale fork of the PostgreSQL version policy, and duplicated Application architecture. Plan now routes to the three pages it introduces, and the deployment-method comparison moves to a new Deploy the Server landing page next to the install paths it describes, keeping the widely deep-linked #deployment-options anchor. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: remove stray line-number prefixes breaking the MDX build The two new Deployment Guide pages were written with editor gutter markers embedded in the text, which put "10|" inside the CardGrid expressions and failed the acorn parse. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: replace em dashes with plain punctuation on the new Plan pages Co-authored-by: Cursor <cursoragent@cursor.com> * docs: trim the remaining sidebar generator comments Removes comments that narrate what the next line does, restate a value that is visible beside them, or recount how a group came to be arranged this way. Keeps the ones stating something the code cannot: ordering rationale, why a page is hidden or duplicated, and the frontmatter a contributor has to set. Generated sidebar output is byte-identical. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: tighten the Deployment Guide index intro The Start here paragraph told readers they were on the starting point of the guide, which the page title already says. Frames the two exceptions by what the reader wants rather than how new they are, since evaluating first is a reasonable choice at any experience level. Renames "When something goes wrong" to Troubleshooting, matching the page it points at and the term readers search for. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: give each Prepare prerequisite its own page The Prepare landing page carried the PostgreSQL, file storage, and network procedures inline while also acting as the group hub. That left PostgreSQL, the required database, with no sidebar entry, so the deprecated MySQL page was the only database topic visible in the nav and read as a duplicate of the landing page above it. Split those three procedures into their own pages, reduce the landing page to a hub, and sort MySQL last. Drops a System requirements section that restated software-hardware-requirements and then linked to it anyway, plus a stale instruction to return to the Linux install that predates this page becoming a hub for all three methods. Deep links had to be repointed by hand rather than redirected, because gen-active-redirects.mjs drops any redirect whose source contains an anchor. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: move Deployment Solution Programs to Support and Community Most of that page is a compliance spec for third parties building installers, not guidance for anyone deploying Mattermost, so it does not belong in the Deployment Guide's Plan group. Renames Get Help to Support and Community so the section can hold it. The Plan and Deploy landing pages still link to it, and the old paths redirect. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: pair bulk import with bulk export under Manage Bulk import sat under Onboard users > Accounts, but it imports teams, channels, posts, and emoji as well as users, and it is the format reference the bulk export page already points readers to. Move it beside bulk export in the sidebar so the two halves of one JSONL format sit together, and rename both to name the task rather than the mechanism. The file stays put on disk, so no URLs move and no redirects are needed. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: place deployment troubleshooting next to the steps that break The single Troubleshoot Deployments category made a reader in a failure state browse a separate top-level section, and left Desktop App Deployment and Mobile App Deployment with no troubleshooting entry of their own. Prev/next walked out of those sections and only a prose link pointed back. Move each surface-specific page beside the step that produces its errors: the database pages follow their setup pages under Prepare, Docker joins the Containers group, and the desktop and mobile pages close their own sections. Only the cross-cutting page, which covers log review, environment review, and the data to gather for a support ticket, has no section home. It stays at the guide root as the single entry point for a reader who cannot yet attribute the failure, and picks up the retired hub's by-layer list. The hub was an eleven-line list of its own children, so removing it costs no content. Its URL redirects to the page that replaced it, and the legacy /guides/deployment-troubleshooting entry was repointed so it does not chain through two hops. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: restructure deployment, admin, and integrations navigation Group the operator's end-to-end path under a Server deployment parent so the deployment guide's top level reads as a sequence, and dissolve Scale by moving sizing into Plan and search and Redis setup into Prepare. Consolidate the admin guide's migration topics into one section after Upgrade, rename Users and access to Access control, and drop the nesting that paired MFA with the deprecated certificate-based auth page. Lead the integrations guide with pre-built integrations before the custom-build material, and remove the Mattermost-built plugins table that duplicated the pre-built integrations page. Pages leaving the sidebar keep working URLs: PostgreSQL troubleshooting folds into the database setup page with a redirect, while the MySQL pages and certificate-based auth stay published but unlisted. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: move high availability into Prepare, rename Migration to Migrate High availability cluster-based deployment reads as setup work against real infrastructure, so it moves from Plan to Prepare alongside search and Redis. The file moves with it, from scale/ to server/ where the other Prepare pages live, which changes its URL: the four legacy redirects now target the new path and the old Docusaurus URL gets one of its own. Rename the admin guide's Migration section to Migrate so all seven sections are verbs, and add it to the guide index, which had no bullet for it. Two neighbouring bullets were stale after the earlier restructure: Onboard users still claimed to cover migrating from another platform, and Manage still referred to Users and access and data export. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: drop the sidebar labels masking admin guide page titles Twenty admin guide pages carried a sidebar_label that showed a different, shorter string in the nav than the page's own title. The nav now falls back to each title, so what a reader clicks matches the heading they land on. The titles themselves are unchanged, which means the SAML pages read "Configure SAML with Okta" under a category already called SAML. Fixing those titles is a separate change. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: restore the optional and recommended prefixes on Prepare steps Three Prepare steps lost an "(Optional)" or "(Recommended)" prefix during the IA reorganisation. The prefix tells an operator scanning the sidebar which steps they can skip, which the bare verb form doesn't. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: shorten the AD/LDAP sync groups page title "Manage team and private channel membership with AD/LDAP sync groups" was the longest entry in the nav. Drop "private" so the sidebar stays scannable. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: drop the note about the withdrawn AKS guide The AKS page was removed in ab62783 and its legacy URL already redirects to this page, so the note explained an absence the reader can't perceive. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )