[pull] master from mattermost:master - #946
Merged
Merged
Conversation
* Add ESLint rule to dedupe System Console config dependencies Introduce @mattermost/no-redundant-admin-config-deps so admin_definition settings that depend on a bool parent via stateIsFalse do not repeat that parent's config/state isDisabled checks, matching the dependency-tree approach discussed on #38024. Co-authored-by: Jesse Hallam <lieut-data@users.noreply.github.com> * Remove redundant System Console isDisabled config checks Drop duplicated parent config/state conditions from SAML and OAuth DCR settings now covered by bool parent dependencies, as enforced by @mattermost/no-redundant-admin-config-deps. Co-authored-by: Jesse Hallam <lieut-data@users.noreply.github.com> * Attribute redundant admin config deps to closest parent Build the full bool-parent dependency tree before reporting, then pick the most specific immediate parent that implies a condition so grandparent-first declaration order cannot mislabel the fix target. Co-authored-by: Jesse Hallam <lieut-data@users.noreply.github.com> * Fix eslint-plugin lint violations in admin config deps rule Resolve no-nested-ternary, wrap-regex, no-unused-vars, no-underscore-dangle, and lines-around-comment issues so Web App CI check-lint passes on the new rule and its tests. Co-authored-by: Jesse Hallam <lieut-data@users.noreply.github.com> * Harden admin config deps rule for regex keys and parent parse Keep distinct regex patterns from collapsing to the same canonicalize key, and skip non-JSON identifier parent args instead of throwing. Co-authored-by: mattermost-code <matty-code@mattermost.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Jesse Hallam <lieut-data@users.noreply.github.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )