[pull] develop from marktext:develop - #46
Merged
Merged
Conversation
…ms (#4374) (#4376) * fix(muyajs): split correct paragraph on Enter in multi-block list items (#4374) enterHandler walked up from <p> to the parent <li> and then called chopBlockByCursor(li.children[0], start.key, ...) — assuming the active line lives in li.children[0] (or [1] for task lists). For loose lists, items with nested sublists, or task items with trailing paragraphs the caret's span is not under children[0], so findIndex returned -1 and the next statement crashed on `children[-1].nextSibling = null`. Capture the active paragraph before the block→li promotion, look it up in li.children, and migrate the blocks after it (sublist and/or trailing paragraphs) into the new li so split semantics preserve order. Added a defensive `index === -1` early return inside chopBlockByCursor. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(muyajs): address Copilot review on #4376 - chopBlockByCursor: return a well-formed empty paragraph via createBlockP('') in the index === -1 guard, so downstream code that assumes p.children[0] exists keeps the invariant. - issue-4374 spec: assert one extra <li> is rendered after splitting a single-paragraph list item, so the sanity check catches functional regressions (not just crashes). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…) (#4378) - graphite: switch --itemBgColor from a dark semi-transparent value to #e5e5e5 so the "New File" / "Open Folder" buttons are legible on the light page background. - el-switch: make the checked state use --themeColor instead of the Element Plus default blue, matching el-slider which already follows --themeColor. - el-radio: make the checked dot use --themeColor while keeping the label text in the normal color (no highlight on the active label). - el-select dropdown: paint the selected item with --themeColor and a --themeColor10 background; use --themeColor for the trigger focus ring as well. - el-input: use --themeColor for the focus ring. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )