Repository navigation
[pull] main from TryGhost:main - #1516
Merged
Merged
Conversation
no ref Field commits (title, feature image, settings) and body autosave used different eligibility checks. All content saves now go through the save engine and one whole-document validator. Published, scheduled and sent edits still wait for Update or Cmd-S. When local validation blocks a save, for example an emptied author list, title, body and image edits stay pending together and the editor shows why. Correcting the problem saves the combined document.
no ref Moved the post debug screen to React and Shade at the existing URL and removed the Ember screen and its styles. Dates and custom refetch ranges use Temporal. There's been a design update. --------- Co-authored-by: Steve Larson <9larsons@gmail.com>
no ref Added smoke tests in e2e covering the editor sidebar, which previously were not covered outside of acceptance tests.
no ref Two Cmd-K acceptance tests dispatched their shortcut as soon as the sidebar search button appeared. The button is gated on the current user, while React's shortcut is registered by an effect after the Labs config arrives, so CI could observe `dispatchShortcut() === false` during startup.
Long documents could expand the outer Admin layout and scroll the React editor controls out of view. The editor now stays bounded by the viewport, with content scrolling behind floating controls. Back navigation uses the shared PageHeader action; save status, word count, and help use button-sized pills with translucent backgrounds and blur. Session warnings reserve space below the header. The settings panel uses the main navigation’s grey surface and rounded border, with 8px spacing at the top, right, and bottom. It opens and closes over 450ms with easing and fading contents. One persistent toggle stays fixed above the panel, including in subviews; it is transparent at rest when open and grey on hover. Preview, Publish, and the footer move left with the sidebar, while a 12px content inset separates full-width cards from the panel without moving the scrollbar. Full-width cards account for the writing area’s actual width throughout transitions and wider settings subviews. Narrow screens retain an overlay panel, and reduced-motion preferences disable transitions. Fixes https://linear.app/ghost/issue/PLA-455/floating-shell Validation: - Synced with main, preserving the new global search provider and the editor height constraint. - Admin typecheck passed. - Editor unit suite: 1,211 tests across 69 files passed after the merge. - Browser acceptance: all 16 editor shell regressions passed, including full-width images beside normal/wide settings and stationary toggle behavior. Another 80 layout, global-search, dunning, and keyboard-shortcut cases passed across focused runs; the shortcut width assertion was corrected and its 7-case suite rerun successfully. - Commit hooks check formatting, lint, dependency boundaries, and secrets. - Earlier full-repository validation encountered unrelated Core cron, gift-preview timeout, and email-date failures; a full repository pass is not claimed. Current-head GitHub CI is monitored separately. - [x] I've read and followed the Contributor Guide - [x] I've explained my change - [x] I've written an automated test to prove my change works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )