[pull] main from TryGhost:main

apps/admin/src/editor/editor-settings-code-injection.acceptance.test.tsx

@@ -6,6 +6,8 @@ import {
   codeInjectionHeadLabel,
   codeInjectionPageFootLabel,
   codeInjectionPageHeadLabel,
+  settingsCodeInjectionBackButton,
+  settingsCodeInjectionRow,
 } from '@tryghost/test-data/selectors/editor';
 
 import {
@@ -34,8 +36,6 @@ const PAGE_ROUTE = new RegExp(`^/pages/${POST_ID}/\\?`);
 // The panel's own width, and the width the wide pane widens it to.
 const PANEL_WIDTH = 350;
 const WIDE_PANEL_WIDTH = 500;
-const BACK_LABEL = 'Close code injection panel';
-const ROW_LABEL = 'Code injection';
 
 const POLL = { timeout: 10_000 };
 
@@ -102,7 +102,7 @@ function footEditor() {
 async function openCodeInjection() {
   await editorScreen.settingsToggle().click();
   await expect.element(editorScreen.settingsSidebar()).toBeVisible();
-  await editorScreen.settingsSubviewRow(ROW_LABEL).click();
+  await editorScreen.settingsSubviewRow(settingsCodeInjectionRow).click();
   await expect.element(editorScreen.settingsSubviewPane()).toBeVisible();
   await expect.element(headEditor()).toBeVisible();
   await expect.element(footEditor()).toBeVisible();
@@ -138,11 +138,11 @@ describe('Post settings code injection', () => {
     await expect(editorScreen.settingsExcerpt()).toHaveCount(0);
     expect(sidebarWidthPx()).toBe(WIDE_PANEL_WIDTH);
 
-    await editorScreen.settingsSubviewBack(BACK_LABEL).click();
+    await editorScreen.settingsSubviewBack(settingsCodeInjectionBackButton).click();
 
     await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
     await expect.element(editorScreen.settingsExcerpt()).toBeVisible();
-    await expect.element(editorScreen.settingsSubviewRow(ROW_LABEL)).toBeVisible();
+    await expect.element(editorScreen.settingsSubviewRow(settingsCodeInjectionRow)).toBeVisible();
     // The panel goes back to the width the section list is shown at.
     await expect.poll(sidebarWidthPx).toBe(PANEL_WIDTH);
   });
@@ -153,11 +153,13 @@ describe('Post settings code injection', () => {
     await openCodeInjection();
 
     // Opening a pane leaves the writer on its back button.
-    await expect.element(editorScreen.settingsSubviewBack(BACK_LABEL)).toHaveFocus();
+    await expect
+      .element(editorScreen.settingsSubviewBack(settingsCodeInjectionBackButton))
+      .toHaveFocus();
     await userEvent.keyboard('{Escape}');
 
     await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
-    await expect.element(editorScreen.settingsSubviewRow(ROW_LABEL)).toBeVisible();
+    await expect.element(editorScreen.settingsSubviewRow(settingsCodeInjectionRow)).toBeVisible();
   });
 
   it('keeps the pane open on Escape inside an editor', async () => {
@@ -196,7 +198,7 @@ describe('Post settings code injection', () => {
     await renderAdminApp(`/editor/page/${POST_ID}`, FLAG_ON);
     await editorScreen.settingsToggle().click();
     await expect.element(editorScreen.settingsSidebar()).toBeVisible();
-    await editorScreen.settingsSubviewRow(ROW_LABEL).click();
+    await editorScreen.settingsSubviewRow(settingsCodeInjectionRow).click();
 
     await expect
       .element(editorScreen.settingsCodeInjection(codeInjectionPageHeadLabel))
@@ -274,14 +276,14 @@ describe('Post settings code injection', () => {
 
     await typeInto(headEditor(), '<script>onClose();</script>');
     await expect.element(headEditor()).toHaveFocus();
-    await editorScreen.settingsSubviewBack(BACK_LABEL).click();
+    await editorScreen.settingsSubviewBack(settingsCodeInjectionBackButton).click();
 
     await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
     await expect(saveApi).toHaveSavedFields({
       codeinjection_head: '<script>onClose();</script>',
     });
 
-    await editorScreen.settingsSubviewRow(ROW_LABEL).click();
+    await editorScreen.settingsSubviewRow(settingsCodeInjectionRow).click();
     await expect.element(headEditor()).toHaveTextContent('<script>onClose();</script>');
   });
 

apps/admin/src/editor/editor-settings-facebook-card.acceptance.test.tsx

@@ -1,5 +1,9 @@
 import { describe, expect, it } from 'vitest';
 import { userEvent } from 'vitest/browser';
+import {
+  settingsFacebookCardBackButton,
+  settingsFacebookCardRow,
+} from '@tryghost/test-data/selectors/editor';
 
 import {
   UNSPLASH_PICKED,
@@ -25,7 +29,6 @@ const POST_ID = 'abc123';
 const CURRENT_USER_ID = '1';
 const FLAG_ON = withoutAutosave({ labs: { editorReact: true } });
 const PUBLISHED_AT = '2025-12-01T10:00:00.000Z';
-const BACK_LABEL = 'Close Facebook card panel';
 const UPLOADED = 'https://example.com/content/images/2026/09/hills.png';
 const FEATURE = 'https://example.com/content/images/2026/09/coast.png';
 // The site fixture's own description, which the card falls back to last.
@@ -69,7 +72,7 @@ function fakeSavablePost(overrides: Partial<SavedPost> = {}) {
 async function openFacebookCard() {
   await editorScreen.settingsToggle().click();
   await expect.element(editorScreen.settingsSidebar()).toBeVisible();
-  await editorScreen.settingsSubviewRow('Facebook card').click();
+  await editorScreen.settingsSubviewRow(settingsFacebookCardRow).click();
   await expect.element(editorScreen.settingsSubviewPane()).toBeVisible();
 }
 
@@ -105,9 +108,9 @@ describe('Post settings Facebook card', () => {
         );
         await expect.poll(() => uploadApi.requests.length, POLL).toBe(1);
         await expect.element(editorScreen.settingsFacebookImageInput()).toBeDisabled();
-        await editorScreen.settingsSubviewBack(BACK_LABEL).click();
+        await editorScreen.settingsSubviewBack(settingsFacebookCardBackButton).click();
         await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
-        await editorScreen.settingsSubviewRow('Facebook card').click();
+        await editorScreen.settingsSubviewRow(settingsFacebookCardRow).click();
         await expect.element(editorScreen.settingsSubviewPane()).toBeVisible();
         await expect.element(editorScreen.settingsFacebookImageInput()).toBeDisabled();
         await expect.element(editorScreen.settingsFacebookImageUnsplashButton()).toBeDisabled();
@@ -136,13 +139,13 @@ describe('Post settings Facebook card', () => {
     await expect.element(editorScreen.settingsFacebookTitle()).toBeVisible();
     await expect
       .element(editorScreen.settingsSidebar())
-      .toHaveAttribute('aria-label', 'Facebook card');
+      .toHaveAttribute('aria-label', settingsFacebookCardRow);
 
-    await editorScreen.settingsSubviewBack(BACK_LABEL).click();
+    await editorScreen.settingsSubviewBack(settingsFacebookCardBackButton).click();
 
     await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
     await expect.element(editorScreen.settingsExcerpt()).toBeVisible();
-    await expect.element(editorScreen.settingsSubviewRow('Facebook card')).toBeVisible();
+    await expect.element(editorScreen.settingsSubviewRow(settingsFacebookCardRow)).toBeVisible();
   });
 
   it('saves an uploaded Facebook image as soon as it lands', async () => {

apps/admin/src/editor/editor-settings-keyboard-shortcuts.acceptance.test.tsx

@@ -1,6 +1,10 @@
 import { describe, expect, it, onTestFinished } from 'vitest';
 import { page, userEvent } from 'vitest/browser';
 import { buildLexicalParagraph } from '@tryghost/test-data';
+import {
+  settingsKeyboardShortcutsBackButton,
+  settingsKeyboardShortcutsRow,
+} from '@tryghost/test-data/selectors/editor';
 
 import {
   currentUserResponse,
@@ -18,8 +22,6 @@ const POST_ID = 'abc123';
 const CURRENT_USER_ID = '1';
 const FLAG_ON = { labs: { editorReact: true } };
 const ROUTE = new RegExp(`^/posts/${POST_ID}/\\?`);
-const BACK_LABEL = 'Close keyboard shortcuts panel';
-const ROW_LABEL = 'Keyboard shortcuts';
 const MAC_AGENT =
   'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36';
 const WINDOWS_AGENT =
@@ -63,7 +65,7 @@ function fakeEditablePost(overrides: Partial<ReturnType<typeof post>> = {}) {
 async function openShortcuts() {
   await editorScreen.settingsToggle().click();
   await expect.element(editorScreen.settingsSidebar()).toBeVisible();
-  await editorScreen.settingsSubviewRow(ROW_LABEL).click();
+  await editorScreen.settingsSubviewRow(settingsKeyboardShortcutsRow).click();
   await expect.element(editorScreen.settingsSubviewPane()).toBeVisible();
 }
 
@@ -79,14 +81,20 @@ describe('Post settings keyboard shortcuts', () => {
 
     // The pane replaces the list it was opened from.
     await expect(editorScreen.settingsExcerpt()).toHaveCount(0);
-    await expect.element(editorScreen.settingsSidebar()).toHaveAttribute('aria-label', ROW_LABEL);
-    await expect.element(page.getByRole('heading', { level: 2, name: ROW_LABEL })).toBeVisible();
+    await expect
+      .element(editorScreen.settingsSidebar())
+      .toHaveAttribute('aria-label', settingsKeyboardShortcutsRow);
+    await expect
+      .element(page.getByRole('heading', { level: 2, name: settingsKeyboardShortcutsRow }))
+      .toBeVisible();
 
-    await editorScreen.settingsSubviewBack(BACK_LABEL).click();
+    await editorScreen.settingsSubviewBack(settingsKeyboardShortcutsBackButton).click();
 
     await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
     await expect.element(editorScreen.settingsExcerpt()).toBeVisible();
-    await expect.element(editorScreen.settingsSubviewRow(ROW_LABEL)).toBeVisible();
+    await expect
+      .element(editorScreen.settingsSubviewRow(settingsKeyboardShortcutsRow))
+      .toBeVisible();
   });
 
   it('lists every shortcut under the group it belongs to, without widening the panel', async () => {
@@ -156,7 +164,9 @@ describe('Post settings keyboard shortcuts', () => {
     await userEvent.keyboard('{Escape}');
 
     await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
-    await expect.element(editorScreen.settingsSubviewRow(ROW_LABEL)).toHaveFocus();
+    await expect
+      .element(editorScreen.settingsSubviewRow(settingsKeyboardShortcutsRow))
+      .toHaveFocus();
   });
 
   it('gives a contributor the same reference list', async () => {

apps/admin/src/editor/editor-settings-meta-data.acceptance.test.tsx

@@ -1,5 +1,9 @@
 import { describe, expect, it } from 'vitest';
 import { page, userEvent } from 'vitest/browser';
+import {
+  settingsMetaDataBackButton,
+  settingsMetaDataRow,
+} from '@tryghost/test-data/selectors/editor';
 
 import {
   currentUserResponse,
@@ -22,7 +26,6 @@ const POST_ID = 'abc123';
 const CURRENT_USER_ID = '1';
 const FLAG_ON = withoutAutosave({ labs: { editorReact: true } });
 const PUBLISHED_AT = '2025-12-01T10:00:00.000Z';
-const BACK_LABEL = 'Close meta data panel';
 const PLACEHOLDER =
   'Search engines will automatically show a custom preview of content related to the search term here if no custom meta description is set.';
 
@@ -59,7 +62,7 @@ function fakeSavablePost(overrides: Partial<SavedPost> = {}) {
 async function openMetaData() {
   await editorScreen.settingsToggle().click();
   await expect.element(editorScreen.settingsSidebar()).toBeVisible();
-  await editorScreen.settingsSubviewRow('Meta data').click();
+  await editorScreen.settingsSubviewRow(settingsMetaDataRow).click();
   await expect.element(editorScreen.settingsSubviewPane()).toBeVisible();
 }
 
@@ -82,20 +85,24 @@ describe('Post settings meta data', () => {
     await expect(editorScreen.settingsExcerpt()).toHaveCount(0);
     await expect.element(editorScreen.settingsMetaTitle()).toBeVisible();
 
-    await editorScreen.settingsSubviewBack(BACK_LABEL).click();
+    await editorScreen.settingsSubviewBack(settingsMetaDataBackButton).click();
 
     await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
     await expect.element(editorScreen.settingsExcerpt()).toBeVisible();
-    await expect.element(editorScreen.settingsSubviewRow('Meta data')).toBeVisible();
+    await expect.element(editorScreen.settingsSubviewRow(settingsMetaDataRow)).toBeVisible();
   });
 
   it('names the panel after the pane it is showing', async () => {
     fakeSavablePost();
     await renderAdminApp(`/editor/post/${POST_ID}`, FLAG_ON);
     await openMetaData();
 
-    await expect.element(editorScreen.settingsSidebar()).toHaveAttribute('aria-label', 'Meta data');
-    await expect.element(page.getByRole('heading', { level: 2, name: 'Meta data' })).toBeVisible();
+    await expect
+      .element(editorScreen.settingsSidebar())
+      .toHaveAttribute('aria-label', settingsMetaDataRow);
+    await expect
+      .element(page.getByRole('heading', { level: 2, name: settingsMetaDataRow }))
+      .toBeVisible();
   });
 
   it('closes the pane on Escape', async () => {
@@ -106,7 +113,7 @@ describe('Post settings meta data', () => {
     await userEvent.keyboard('{Escape}');
 
     await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
-    await expect.element(editorScreen.settingsSubviewRow('Meta data')).toBeVisible();
+    await expect.element(editorScreen.settingsSubviewRow(settingsMetaDataRow)).toBeVisible();
   });
 
   it('leaves the pane open for an Escape the preview has already answered', async () => {
@@ -138,7 +145,7 @@ describe('Post settings meta data', () => {
       await userEvent.keyboard('{Escape}');
 
       await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
-      await expect.element(editorScreen.settingsSubviewRow('Meta data')).toHaveFocus();
+      await expect.element(editorScreen.settingsSubviewRow(settingsMetaDataRow)).toHaveFocus();
       await expect(saveApi).toHaveSavedFields({
         [`meta_${field}`]: 'Saved when the pane closes',
       });
@@ -151,14 +158,21 @@ describe('Post settings meta data', () => {
     await openMetaData();
 
     await expect
-      .poll(() => document.activeElement === editorScreen.settingsSubviewBack(BACK_LABEL).element())
+      .poll(
+        () =>
+          document.activeElement ===
+          editorScreen.settingsSubviewBack(settingsMetaDataBackButton).element(),
+      )
       .toBe(true);
 
-    await editorScreen.settingsSubviewBack(BACK_LABEL).click();
+    await editorScreen.settingsSubviewBack(settingsMetaDataBackButton).click();
 
-    await expect.element(editorScreen.settingsSubviewRow('Meta data')).toBeVisible();
+    await expect.element(editorScreen.settingsSubviewRow(settingsMetaDataRow)).toBeVisible();
     await expect
-      .poll(() => document.activeElement === editorScreen.settingsSubviewRow('Meta data').element())
+      .poll(
+        () =>
+          document.activeElement === editorScreen.settingsSubviewRow(settingsMetaDataRow).element(),
+      )
       .toBe(true);
   });
 
@@ -173,7 +187,7 @@ describe('Post settings meta data', () => {
 
     await expect.element(editorScreen.settingsSidebar()).toBeVisible();
     await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
-    await expect.element(editorScreen.settingsSubviewRow('Meta data')).toBeVisible();
+    await expect.element(editorScreen.settingsSubviewRow(settingsMetaDataRow)).toBeVisible();
   });
 
   it('persists a draft’s meta title and description on the blur that ends each edit', async () => {

apps/admin/src/editor/editor-settings-tags.acceptance.test.tsx

@@ -1,6 +1,7 @@
 import { describe, expect, it } from 'vitest';
 import { userEvent } from 'vitest/browser';
 import { buildLexicalParagraph } from '@tryghost/test-data';
+import { settingsTagsCreateText } from '@tryghost/test-data/selectors/editor';
 
 import {
   currentUserResponse,
@@ -185,7 +186,7 @@ describe('Post settings tags', () => {
     await openTagList();
 
     await editorScreen.settingsTagsInput().fill('Culture');
-    await editorScreen.settingsTagOption('Create “Culture”').click();
+    await editorScreen.settingsTagOption(`${settingsTagsCreateText} “Culture”`).click();
 
     await expect.poll(() => saveApi.requests.length, POLL).toBe(1);
     // Named, not created first: an abandoned edit leaves no stray tag behind.
@@ -252,7 +253,9 @@ describe('Post settings tags', () => {
 
     // A comma is an ordinary character in a tag name, not a separator.
     await editorScreen.settingsTagsInput().fill('Arts, Culture');
-    await expect.element(editorScreen.settingsTagOption(/Create/)).toBeVisible();
+    await expect
+      .element(editorScreen.settingsTagOption(new RegExp(settingsTagsCreateText)))
+      .toBeVisible();
     await userEvent.keyboard('{Tab}');
 
     await expect.poll(() => saveApi.requests.length, POLL).toBe(1);

apps/admin/src/editor/editor-settings-x-card.acceptance.test.tsx

@@ -1,5 +1,6 @@
 import { describe, expect, it } from 'vitest';
 import { page, userEvent } from 'vitest/browser';
+import { settingsXCardBackButton, settingsXCardRow } from '@tryghost/test-data/selectors/editor';
 
 import {
   UNSPLASH_PICKED,
@@ -25,7 +26,6 @@ const POST_ID = 'abc123';
 const CURRENT_USER_ID = '1';
 const FLAG_ON = withoutAutosave({ labs: { editorReact: true } });
 const PUBLISHED_AT = '2025-12-01T10:00:00.000Z';
-const BACK_LABEL = 'Close X card panel';
 const UPLOADED = 'https://example.com/content/images/2026/09/hills.png';
 const FEATURE = 'https://example.com/content/images/2026/09/coast.png';
 // The site fixture's own description, which the card falls back to last.
@@ -75,7 +75,7 @@ function fakeImageUpload() {
 async function openXCard() {
   await editorScreen.settingsToggle().click();
   await expect.element(editorScreen.settingsSidebar()).toBeVisible();
-  await editorScreen.settingsSubviewRow('X card').click();
+  await editorScreen.settingsSubviewRow(settingsXCardRow).click();
   await expect.element(editorScreen.settingsSubviewPane()).toBeVisible();
 }
 
@@ -111,9 +111,9 @@ describe('Post settings X card', () => {
         );
         await expect.poll(() => uploadApi.requests.length, POLL).toBe(1);
         await expect.element(editorScreen.settingsXImageInput()).toBeDisabled();
-        await editorScreen.settingsSubviewBack(BACK_LABEL).click();
+        await editorScreen.settingsSubviewBack(settingsXCardBackButton).click();
         await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
-        await editorScreen.settingsSubviewRow('X card').click();
+        await editorScreen.settingsSubviewRow(settingsXCardRow).click();
         await expect.element(editorScreen.settingsSubviewPane()).toBeVisible();
         await expect.element(editorScreen.settingsXImageInput()).toBeDisabled();
         await expect.element(editorScreen.settingsXImageUnsplashButton()).toBeDisabled();
@@ -143,11 +143,11 @@ describe('Post settings X card', () => {
     await expect.element(editorScreen.settingsXDescription()).toBeVisible();
     await expect.element(editorScreen.settingsXImage()).toBeVisible();
 
-    await editorScreen.settingsSubviewBack(BACK_LABEL).click();
+    await editorScreen.settingsSubviewBack(settingsXCardBackButton).click();
 
     await expect(editorScreen.settingsSubviewPane()).toHaveCount(0);
     await expect.element(editorScreen.settingsExcerpt()).toBeVisible();
-    await expect.element(editorScreen.settingsSubviewRow('X card')).toBeVisible();
+    await expect.element(editorScreen.settingsSubviewRow(settingsXCardRow)).toBeVisible();
   });
 
   it('saves an uploaded X image as soon as it lands', async () => {