Repository navigation
[pull] main from TryGhost:main - #1513
Merged
Merged
Conversation
…30956) ref https://linear.app/ghost/issue/PLA-293 Registers a new `globalSearchReact` private Labs flag for moving the Cmd-K search modal from Ember to React.
…30945) no ref The React editor would prompt for save on whitespace changes. This removes that, and we always trim the title for change detection.
…rows (#30949) no ref Tier and snippets menu now use pagination as expected.
no ref Cleanup: the React editor's change tracker included some fields that were unread.
no ref This is an improvement on the Ember editor - we now fetch pages of 100 up to 1000 labels. Eventually we may want to improve this to support search-as-you-type.
Adds a location map to member profiles, using the country and US state data Ghost already stores. This is the implementation intended for general release after internal testing; the private `memberLocationMap` Labs flag remains off by default in this PR. - Uses `country_code` as the source of truth and resolves US regions from state names, postal abbreviations, and `US-XX` codes. Pins indicate approximate country/state locations, not member coordinates. - Renders a continuous Mercator world map from local, public-domain Natural Earth geometry. No external map service, API key, or location data transmission is involved. The view includes surrounding geography and keeps the pin centered. - Places the avatar beside the member heading and removes the duplicate sidebar identity when enabled. Unknown countries show no map; US members without a recognized state show an overview without a pin. New-member forms retain their existing layout. - Lazy-loads the map and keeps header controls usable if the download fails. The current map chunk is about 510 kB compressed. - Uses `MemberLocationMap` naming throughout. Temporary spike notes and the standalone sample preview (including its HTML, entry point, and Vite config) are removed. A short NOTICE records the dataset source and public-domain status; regeneration commands live in the generator header. Internal rollout: Enable developer experiments, then **Settings → Labs → Private features → Member location maps**. The flag controls the entire map/header change and defaults off; disabled or older-backend configurations preserve the existing member page. Test the integrated member page with country locations, US state names/codes, Alaska and Hawaii, missing locations, and narrow/light/dark layouts. Check load time on slower connections and the locations represented in actual member data; small territories may be absent from the Natural Earth 50m dataset. After internal sign-off, a follow-up PR will remove the private flag and its toggle, make this header the default, remove the old flag-off layout branches, and update the rollout tests. This PR does not enable general availability. Validation: - After cleanup: 35 map/header/formatting unit tests and 5 browser acceptance cases passed, including disabled/missing flags, unknown locations, and new-member forms. - Admin TypeScript, focused lint, and a production React bundle build passed. The build used a temporary output directory with the Ember publishing hook disabled to preserve the running local Admin assets. - After syncing with `main` (`33fbb7f603`): 19 Core Labs unit tests, repository formatting, and repository lint passed. The full `pnpm check` test phase reported 22 Core failures across 8 files outside the map feature, including email rendering, gift preview, staff notifications, automation, and request-queue tests, with many timeouts. Remaining broad suites were stopped after these failures; this was not a green full-suite result. - Earlier validation covered config/settings APIs, member editing/navigation, and visual checks across desktop/mobile and light/dark themes. CI runs again for the updated PR. - [x] I've read and followed the Contributor Guide - [x] I've explained my change - [x] I've written automated tests
#30952) no ref Filled in some missing role-based tests for the React editor.
…an publish (#30963) no ref The React editor's post preview modal now shows its Publish button for every user who can publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )