[pull] main from TryGhost:main - #1501
Merged
Merged
Conversation
towards https://linear.app/ghost/issue/NY-1621 This change should have no user impact. This renders automations' descriptions from the server, if applicable. They're not sent today, but they will be in a future change! In addition to automated tests, I also manually verified this by hacking the backend API endpoint to send a description: 
…t are built Portal's type check reads @tryghost/metafield-types from that package's build output, but nothing told Nx to build it first. CI only passed while another project in the same run happened to build it, so a change touching Portal alone failed to find the module. Portal's lint now declares the build it needs, the same way Admin's does.
no ref Each row of an address was a component declared inside the field, so every render made a new component type and React replaced the row's inputs. Typing a key re-renders the field, so the input a member was typing in was torn down after the first character and the rest of what they typed went nowhere. Declaring the row once, outside the field, keeps its inputs mounted across renders. The new browser test types an address line a key at a time and checks the input keeps focus and the whole value.
towards https://linear.app/ghost/issue/NY-1622 Should have no user impact. I think this is a useful change on its own, but will also make an upcoming change easier.
towards https://linear.app/ghost/issue/NY-1622 There was no reason for this to return a promise. Should have no user impact. I think this is a useful change on its own, but will also make an upcoming change easier.
no ref Replaces `_.isArray` with `Array.isArray`. `_.isArray` is [just an alias for `Array.isArray`][0], so this should have no effect. [0]: https://github.com/lodash/lodash/blob/cb0b9b9212521c08e3eafe7c8cb0af1b42b6649e/lodash.js#L11385
no ref Renovate has not created or merged a dependency PR in weeks. Two independent faults combined into a deadlock. `allowedPostUpgradeCommands` was renamed to `allowedCommands` in Renovate 41, so `RENOVATE_ALLOWED_POST_UPGRADE_COMMANDS` has been silently ignored since the runner moved to 44. Renovate refused both changeset postUpgradeTask commands, set `renovate/artifacts` to failure on every npm branch, and will not automerge a PR carrying an artifact error. The open-PR cap counted every PR without a `needs:review` label, but that label marks only one of the config's automerge exclusions. Docker digest, pin, and monorepo PRs that Renovate can never merge itself counted against the cap of 6, pinning the count at 7 and holding the runner in maintenance-only mode indefinitely. Counting Renovate's own per-PR automerge marker instead drops the live count to 3 and reopens PR creation. A body missing the marker still counts, so an unparseable PR tightens the cap rather than loosening it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )