[pull] main from TryGhost:main - #1472
Merged
Merged
Conversation
no ref This is a test-only change. Notably, I removed some tests that used invalid types. TypeScript should be checking these things, not runtime tests.
…#30544) no ref No behavior change. This adds some test coverage for the session-expiry redirect handling in the React editor.
no ref This change should have no user impact. Made two changes to the URL service router filter: - Tidied imports and exports - TypeScriptified tests
no ref This is a test-only change. All of these tests are in `test/unit/`. No need for "UNIT" to precede the spec titles. `git grep -w UNIT` returns no results after this change.
ref https://ghost.slack.com/archives/C09K9BSGYQM/p1787840921841429 - In older versions of Ghost, when a staff user was deleted, their posts were deleted too. As a precaution, a backup of the content was created and stored on disc - A newer version of Ghost changed that behaviour so the posts were not deleted, but moved to the Owner user instead and a tag like `#author-slug` was added to the posts. The backup was still taken - This PR removes that backup step, as the moving & tagging of posts has enough data to roll back, should the delete be a mistake. The backup was never easily surfaced to users anyway
no ref _I recommend reviewing this with whitespace changes disabled._ This is a test-only change. We're dropping SQLite support so this is no longer needed.
no ref Added the keyboard save behavior to the E2E tests.
#30558) no ref Includes `author` in the save payload.
…0559) no ref Cleaned up the React editor settings handling to be less fragile.
no ref Added a starter shell for the PSM/sidebar for the React editor. So far only `excerpt` and `featured` are available.
no ref Added a few E2E user journeys for the React editor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )