[pull] main from TryGhost:main - #1465
Merged
Merged
Conversation
no ref Ghost should run on Node 24, but nothing about shipping on it has to change to get there. This declares 24 as supported and leaves 22.23.1 as the default everywhere it is one: devEngines, .nvmrc, .node-version, CI's NODE_VERSION and all three Dockerfiles. Pro keeps building and running the same image. The unit, legacy and acceptance matrices have run on 24 for a while and stayed green through a bug that stopped Ghost booting at all — an ESM/CJS require race on `got` that only fired during init migrations. Those suites stop at module level, so full boot is the coverage that was missing. Ghost-CLI's clean-install scenario is the cheapest place to get it: it installs this build's tarball and starts it, so it now runs on every Node line `engines` claims, off the same list the other matrices use. The latest-release scenario stays on the default. It upgrades from the newest Ghost on npm, and that release's own `engines` decides which Node versions can install it — it can join the full list once a published release supports 24. The debug-log artifact name carries the Node version as well as the scenario, since the clean-install legs would otherwise collide on upload. engines.cli is unchanged: the ^1.29.1 minimum is already above the Ghost-CLI release that added Node 24 support. The renovate @types/node cap also stays at <23, since it tracks the Node version we develop and build against, which is still 22.
no ref The React editor needs the the 'change detection engine' which handles the logic for detecting dirty editor state. This is a port to Typescript with a description of how it works plus significant testing surface.
no ref The React editor needs the the 'save engine' which handles the logic for various save actions (auto vs manual). This is a port to Typescript with a description of how it works plus significant testing surface.
no ref The React post editor needs to ask the server for a deduplicated slug when the title or slug changes. Ember does this through its `slug-generator` service; the framework had no equivalent.
no ref This adds the 'slug machine' as a Typescript module to handle the logic around slug assignment and generation in the migrated Editor activity.
…30469) no ref These hooks have no consumers yet; the editor re-authentication flow that uses them lands separately. The React post editor needs a way to re-authenticate in place when a save hits an expired session. Ember does this through its cookie authenticator; the framework only had `useDeleteSession`.
no ref - rewrites the editor engine documentation around its current contracts and design decisions - removes Ember, migration, and stacked-review context from editor comments and test descriptions - replaces numbered invariant labels with standalone behavior descriptions
…30471) no ref Docs-only change to `apps/admin/src/editor/engine/README.md`, plus four comment edits in `save-engine.ts`.
no ref Adds logic for the forthcoming publish flows.
no ref The logic to hold what a user chooses before a post changes status: publish type, scheduling, newsletter and recipients.
…0477) no ref Wired up the various engines (save, slug, change detection) into one editing session in the React editor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )