[pull] main from TryGhost:main - #1454
Merged
Merged
Conversation
no ref Artifact-backed Docker image transfers leave the compressed image archive in the workspace after docker load. Analytics E2E shards already pull several large service images, so that retained archive can consume the remaining runner disk and cause ENOSPC failures. The canonical registry-backed path does not retain this archive, which makes the failure specific to forks, mirrors, and cross-repository pull requests even though they use the same workflow. Analytics shards also provisioned a separate Buildx builder before knowing whether the prebuilt Tinybird CLI image was available. That added a BuildKit container and image during the disk-critical setup phase, while source-build cache remained until post-job cleanup.
no ref CSV imports need to exercise the serializable jobs contract before M8 adds durable processing. Stage uploads so validation completes before the response while the handler can reparse the staged upload from a pure-data job payload, preserving the temporary in-memory outcomes and 100-row limit. Keep the migration scoped to the current in-memory phase: - Add a serializable job class and central handler registration. - Stage uploads in private temporary files because Multer removes the request upload after the response. - Preflight imports during the request to preserve validation, totals, and the 100-row limit. - Reparse staged uploads in the handler and always attempt cleanup. - Add an `allSettled()` seam so existing E2E tests can deterministically await queued imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )