[pull] main from TryGhost:main - #1451
Merged
Merged
Conversation
no ref _I recommend reviewing this with whitespace changes disabled._ This CI-only change should have no user impact. Ghost has not supported SQLite in production [since 5.0][0], released in 2022. It's partly supported in development, but because we plan to drop it, let's remove the CI jobs. [0]: https://ghost.org/changelog/5/
…30133) ref https://linear.app/ghost/issue/DES-1475/delay-feels-broken-when-toggling-homepage-and-post-in-design-settings The preview reused a single iframe and swapped its URL on every tab change, so switching between Homepage and Post refetched and re-rendered the whole page. Double buffering held the old page on screen until the replacement loaded, so a click produced no visible feedback for the entire round trip and read as broken rather than slow. Each tab now renders its own preview, mounted when the modal opens and kept in sync in the background. Switching tabs only changes which preview is visible, so it never waits on the network. Hidden previews stay mounted and laid out at full size, which avoids a visible re-layout jolt when revealing them in mobile view. The trade-off is that a settings change now refreshes every preview rather than only the visible one, costing an extra background render.
no ref Rebuilds Ghost Admin's posts (`/ghost/#/posts`) and pages (`/ghost/#/pages`) lists in React with full feature parity, behind the private `postsListReact` Labs flag.
no ref Admin lint needs the checkout package declarations on clean CI runners. Build the package before typed linting so its exports resolve without relying on prior artifacts.
closes https://linear.app/ghost/issue/NY-1547 Hide the analytics columns when the automations browse response omits stats. For now, this will make it look the same as we had before we added the stats columns (i.e. no visible header). 
ref https://linear.app/ghost/issue/BER-3875/ - require and validate the buyer name before entering gift delivery details - always include the validated buyer name for email and self-share checkouts - keep delivery-step validation scoped to recipient and scheduling fields
ref https://linear.app/ghost/issue/NY-1540/mobile-view-for-automations-list-table The three stat columns were hidden below `lg`, so on mobile the list showed only a name, description and status. The stats are the reason to open the list at all, and their absence made the screen read as unfinished rather than deliberately condensed. Each row now lays out on a four-track grid below `lg`: the name spans the first row, the stats sit on the second, and the status badge stays pinned right. Placement is explicit rather than wrapping the stats in a container, because a wrapper between `tr` and `td` is invalid markup and would break the real table layout that returns at `lg`. Each stat carries its own label beneath its value, matching the newsletter list in settings, since the column headers are hidden at that width. Column widths are scoped to `lg` so they no longer fight the mobile grid, and the skeleton uses the same layout so nothing shifts as the list loads. The stats render inside the `showRunAnalytics` guard added in #30313, so they stay hidden when the browse response omits stats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )