[pull] main from TryGhost:main - #1449
Merged
Merged
Conversation
ref https://linear.app/ghost/issue/HKG-1971 Handler registration is a composition boundary, so boot now passes the live jobs service, database, and logger explicitly instead of registration resolving process-global dependencies. This also lets focused tests exercise handlers without mutating the jobs-service singleton.
ref https://linear.app/ghost/issue/HKG-1971 Boot needs the concrete ExternalMediaInliner when wiring the class-based job handler. Retaining the instance alongside the unchanged legacy API makes that composition possible without adding a wrapper service or changing dispatch behavior ahead of the migration.
ref https://linear.app/ghost/issue/HKG-1971 External media inlining was the remaining inline task on the legacy job manager. The Admin API now resolves a complete domain payload and dispatches a serializable job, while boot injects the initialized ExternalMediaInliner into central handler registration. This keeps execution separate from dispatch and lets JobsService own lifecycle logging and error reporting.
ref https://linear.app/ghost/issue/BER-3900/ - adds links to Portal for purchasing gift subscriptions - can be disabled through Settings - adds 3 and 6 month durations for gift subscriptions - adds ability to have email subscriptions delivered to recipient via email with a customised message, either immediately or on a scheduled date
no ref CSV imports need to store one discovered media URL at a time without inheriting the existing batch service's content-matching rules. Expose a typed per-URL result directly from the existing CommonJS service while preserving the batch importer's failure boundaries and established module contract, allowing future callers to reuse media downloading and storage without changing existing batch behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )