[pull] main from TryGhost:main - #1435
Merged
Merged
Conversation
no ref *I recommend reviewing this change one commit at a time.* This change: - Adds unit tests for TOTP helpers - Converts TOTP generator to TypeScript - Renames "OTP" to "TOTP" (to disambiguate with "HOTP") - Avoids overwriting global options This should have no user impact.
no ref This should have no user impact. The `sequence` export from `@tryghost/promise` can be replaced with simple `await`s and loops. This brings us closer to removing the package.
no ref `bulkDestroyWhere` was exported from a Bookshelf plugin, but only called in once place. Let's simply inline it. `git grep bulkDestroyWhere` returns no results after this change.
no ref This also rewrites it in a more realistic way, instead of mocking `req` and `res`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )