[pull] main from TryGhost:main - #1434
Merged
Merged
Conversation
The search field in the callout card's emoji picker is now aligned with Shade's input. Clicking outside the picker now closes it, using the same useClickOutside hook as the other popovers in the editor.
no ref Deletion-only prune of Shade code with no consumers anywhere in the repo.
no ref The React user menu signed out with a bare `fetch` that skipped the framework fetch layer's credentials/headers/retry/typed-error handling, and a failure only logged to the console.
no ref Three full-page screens (tag detail, member detail, automations editor) each rolled their own guards with divergent discard dialogs. One admin hook now owns this.
no ref This is a cleanup of Admin API request handling. The theme editor and Labs YAML editor needed text or binary responses, so they bypassed `admin-x-framework` with bare `fetch` calls and repeated URL construction, credentials, error handling, and cache invalidation. This change moves those requests onto the shared fetch layer.
no ref - Consolidates React Router imports and route-handle types - Centralizes analytics timezone lookup - Fixes infinite-query headers being silently dropped - Removes the obsolete Members force-upgrade exemption - Adds focused unit and acceptance coverage Small mechanical leftovers from the navigation and data-layer convergence.
ref https://linear.app/ghost/issue/PLA-137 We desire to stop hand-maintaining style rules in `eslint-plugin-ghost` and move formatting to a dedicated tool with close-to-default settings, converging with the wider ecosystem and with what code agents emit by default. This PR does the one-time reformat and switches enforcement on.
ref https://linear.app/ghost/issue/PLA-137 Follow-up to #30184: lists the reformat squash commit (`5ad154310f`) in `.git-blame-ignore-revs` so blame can attribute reformatted lines to their earlier authors. GitHub's blame view uses the file automatically; `pnpm setup` now configures the repository-local `blame.ignoreRevsFile` setting for local `git blame`. Existing checkouts can rerun `pnpm setup` or use the documented one-time `git config --local blame.ignoreRevsFile .git-blame-ignore-revs` command. Verified locally: with the config set, `git blame` on sampled reformatted files attributes zero lines to the reformat commit.
no ref This change should have no user impact. This is mostly a types-only change, but there were a few spots where we had to make "real" code changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )