[pull] main from TryGhost:main - #1433
Merged
Merged
Conversation
ref https://linear.app/ghost/issue/HKG-1990/add-baseline-execution-logging-to-existing-background-jobs - We're about to move these jobs onto the durable jobs interface and can't currently say how any of them behave in production. All 15 scoped jobs now report a queued/started/completed/failed/skipped lifecycle, tagged with a shared `[Background Job]` marker so the set is searchable as one. - No behaviour change: each wrapper awaits the original callback, returns its result, and rethrows. Scheduling, concurrency, retries, worker control messages, and error propagation are untouched. - Logging goes through a best-effort wrapper that swallows logger failures — observability should never decide whether a job runs. - Only names, cron expressions, durations, and counts are logged. No payloads, member data, tokens, or file contents. - A few pre-existing log strings were reworded to fit the format. Nothing in the repo depends on them, but external dashboards might.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )