[pull] main from TryGhost:main - #1430
Merged
Merged
Conversation
ref https://linear.app/ghost/issue/ONC-1945 The bulk "Add tag" action inserted a `posts_tags` row for every selected post without checking whether the post already had the tag. `posts_tags` has no unique constraint, so re-applying a tag to a selection that already carried it silently created a redundant row per post Those rows are invisible everywhere in the product, because the read path deduplicates by tag `id` before anything renders them. The one place they leak through is the tag post count, which counted join rows rather than distinct posts and so reported roughly double This PR fixes both halves. The bulk action now filters out post/tag pairs that already exist, matching the guard already in place in the users service, and also deduplicates the requested tags so passing the same tag twice in one request no longer inserts twice. The count now uses `countDistinct` so it reports posts rather than links Counting distinct matters independently of the write-side fix: it makes existing affected sites report correctly on upgrade, without a data migration. Removing the redundant rows would change which tag is primary on some posts, and therefore post URLs on sites using a `{primary_tag}` permalink, so leaving them in place is the lower-risk option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )