[pull] main from TryGhost:main - #1427
Merged
Merged
Conversation
…too long Stripe rejects checkout session creation when a custom field label exceeds 50 characters, but the donation personal-note label (a translated Portal string) was only capped at 255 — a limit copied from the donation_message column, which stores the member's answer, a different Stripe field with a different limit. A translation between 51 and 255 characters would therefore break the entire donation checkout for that locale. The label is now bounded on both sides of sanitising: before, because this is a public endpoint and nothing past the limit can survive, so there is no reason to sanitise an unbounded string; and after, because sanitising can lengthen the string and the post-sanitise length is what Stripe measures. Truncating rather than rejecting keeps the label translated, as falling back to the English default would defeat the purpose of the parameter.
A members filter like (newsletters.slug:-weekly+email_disabled:0) says not subscribed to the weekly newsletter, but Admin read it as subscribed, and because Admin writes the parsed filter back on save, opening and saving such a segment silently inverted its meaning. The parser now takes the subscription state from the slug clause's own polarity and treats the email_disabled clause purely as the marker of a newsletter-subscription compound, matching how the legacy Ember admin read these filters.
ref https://linear.app/ghost/issue/BER-3851 Gift delivery also needs to interpret Mailgun send results, so keeping the helper under automations would make a cross-service transport concern appear automation-owned. Moving it to the shared services area gives existing and future mail callers one neutral implementation without changing behavior.
Admin fills in a missing user preference by writing the whole accessibility blob merged over the user it read when the page loaded, and it queues one such write per mounted consumer, so the state the test set through the API landed in between those queued writes and the next one reverted it. Setting the onboarding state now detaches the page from Admin first so the queue is discarded, then retries the write until the server reports the state back, leaving the caller to navigate and load Admin against it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )